test(tile-select): refine testing suite - #8064
Conversation
38519b7 to
d53bc1f
Compare
7b93fa1 to
0447f6b
Compare
5f467ef to
2a327f5
Compare
| }); | ||
|
|
||
| test.describe("check props for TileSelect component", () => { | ||
| testData.forEach((title) => { |
There was a problem hiding this comment.
suggestion: Can we add this into unit testing, as diacritics are not tested anywhere else.
There was a problem hiding this comment.
there's tests for title in the unit tests (node and string), I'm not sure what this adds beyond that, this is just passing a string etc
| await expect(icon2).toBeVisible(); | ||
| }); | ||
|
|
||
| testData.forEach((subtitle) => { |
There was a problem hiding this comment.
suggestion: Can we add this into unit testing, as diacritics are not tested anywhere else.
There was a problem hiding this comment.
there's tests for subtitle in the unit tests (node and string), I'm not sure what this adds beyond that, this is just passing a string etc
| }); | ||
| }); | ||
|
|
||
| testData.forEach((description) => { |
There was a problem hiding this comment.
suggestion: Can we add this into unit testing, as diacritics are not tested anywhere else.
There was a problem hiding this comment.
there's tests for description in the unit tests (node and string), I'm not sure what this adds beyond that, this is just passing a string etc
2415914 to
618c689
Compare
4 participants
Proposed behaviour
menuplaywright test and adds a Chromatic interaction to cover the scenario.Current behaviour
menuplaywright tests fails in this buildChecklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions