Repository navigation
docs: finish the cross-epoch + iCentral doc updates the fix PRs missed - #296
Merged
Merged
Conversation
The post-fix mutation run (@ c7c22c3) found no code defects and no coverage gaps, but its adversarial pass flagged four doc sites the fix PRs (#292-295) left contradicting the hardened code: - README.md cross-epoch invariant section still documented the pre-hardening pauseTimeAfter >= maxAge and called the == maxAge boundary 'airtight' — a config the README calls valid now reverts at init. Rewritten to the strict > maxAge rule with the forward-skew-margin rationale (matches the contract NatSpec), and the config example comment fixed. - DIAVaultOracle maxAge struct-field NatSpec said 'MUST be <= pauseTimeAfter'; init enforces strict <. Corrected (the sibling pauseTimeAfter field was already updated). - MorphoPairAdapterBeaconSetDeployer iCentral immutable's inline comment still said 'fixed for the beacon's whole life', contradicting the struct-field NatSpec corrected in #293. Aligned. - Two DIAVaultOracle test comments still reasoned with the non-strict >= / 'airtight at equality' phrasing. Corrected (assertions were already right). Doc/comment + README only — zero code lines changed. 192 tests; fmt/slither/reuse clean. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013hi8wq9YkjWPcGACXCEKeL
hardyjosh
marked this pull request as ready for review
August 10, 2026 17:26
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doc consistency follow-up surfaced by the post-fix mutation run (@
c7c22c3), which found no code defects and no coverage gaps — every non-equivalent mutant is killed by the existing suite — but flagged four doc sites the fix PRs (#292–#295) left contradicting the hardened code:pauseTimeAfter >= maxAgeand called== maxAge'airtight' — a config it calls valid now reverts at init. Rewritten to the strict> maxAgerule + forward-skew-margin rationale.maxAgestruct-field NatSpec said 'MUST be<= pauseTimeAfter'; init enforces strict<. Corrected.iCentralimmutable comment still said 'fixed for the beacon's whole life', contradicting the struct doc corrected in #293.>=/ 'airtight at equality' phrasing.Doc/comment + README only — zero code lines changed. 192 tests; fmt/slither/reuse clean. Last doc loose end before the pre-audit evidence is regenerated over the final tip.
🤖 Generated with Claude Code