Skip to content

docs(lib): correct which guard term rejects a leaked cancelled pending node #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hardyjosh merged 1 commit into from
Aug 10, 2026
Merged

docs(lib): correct which guard term rejects a leaked cancelled pending node #295

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/lib/LibCorporateActionsPause.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,17 @@ library LibCorporateActionsPause {
// from `ICorporateActionsV1` — cursor `0` is a real bootstrap node and
// must NOT be treated as "no match".
// `effectiveTime == 0` is the documented sentinel for a cancelled
// (unlinked) node; under the upstream unlinking contract such a node
// is never returned by the traversal API, but we reject it here as
// defence-in-depth so a leaked cancelled node cannot yield `(true, 0)`.
// (unlinked) node; under the upstream unlinking contract such a node is
// never returned by the traversal API. On THIS (pending) branch the
// `pendingEffective != 0` conjunct is belt-and-suspenders that is
// actually SUBSUMED by the `pendingEffective > block.timestamp`
// re-assertion below: `0 > block.timestamp` is false, so a leaked
// cancelled node is rejected by that check regardless. The conjunct is
// kept for symmetry and self-documentation, but note it is the
// `> block.timestamp` re-assertion — not the `!= 0` term — that closes
// the phantom-node hole here. (On the COMPLETED branch the `!= 0` twin
// IS load-bearing, because there the re-assertion is `<= block.timestamp`,
// which `0` satisfies.)
if (pendingCursor != NODE_NONE && pendingEffective != 0) {
// Defence-in-depth: re-assert the PENDING filter's invariant
// locally. `pendingEffective > now` is guaranteed server-side by
Expand Down
Loading