refactor(audit): bind AuditableCommand type T + shared Service.runCor…#12
Merged
Conversation
…related (Story 13.7 Phase B) - AuditableCommand: abstract `type T <: AuditableCommand`; withCorrelationId returns T (this.asInstanceOf[T]) so subtypes bind it to their concrete base - sound cast. - Service.runCorrelated(entityId, command, correlationId): shared seam to stamp the cid as DATA (never MDC across the tapir serverLogic Future - C14) onto an AuditableCommand before dispatch; no-op for non-auditable commands. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 4 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
==========================================
- Coverage 61.22% 61.05% -0.17%
==========================================
Files 95 95
Lines 1849 1854 +5
==========================================
Hits 1132 1132
- Misses 717 722 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…related (Story 13.7 Phase B)
type T <: AuditableCommand; withCorrelationId returns T (this.asInstanceOf[T]) so subtypes bind it to their concrete base - sound cast.