Skip to content

Reduce logging level when validating user certificates#62

Merged
kimmo-sk merged 4 commits intoSK-EID:masterfrom
Johxzu:feature/DDS-3046
Apr 23, 2026
Merged

Reduce logging level when validating user certificates#62
kimmo-sk merged 4 commits intoSK-EID:masterfrom
Johxzu:feature/DDS-3046

Conversation

@Johxzu
Copy link
Copy Markdown
Contributor

@Johxzu Johxzu commented Feb 19, 2026

Fixes #59

commenting on pom.xml change:

  • Project uses org.slf4j:slf4j-api:1.7.36 (pom.xml:99).
  • ch.qos.logback:logback-classic:1.3.12 (pom.xml before change) targets SLF4J 2.x and references org.slf4j.spi.LoggingEventAware.
  • That class does not exist in SLF4J 1.7.x, causing:
    • java: cannot access org.slf4j.spi.LoggingEventAware.

So changed Logback to 1.2.13 (pom.xml:132), which is compatible with SLF4J 1.7.x and lets logging-capture tests compile/run.

Alternative would be a broader upgrade to SLF4J 2.x across the project, but that’s a larger migration.

@kaidohallik kaidohallik self-requested a review March 31, 2026 08:52
Comment thread src/test/java/ee/sk/mid/AuthenticationResponseValidatorTest.java
Comment thread src/main/java/ee/sk/mid/MidAuthenticationResponseValidator.java Outdated
Comment thread pom.xml Outdated
@kaidohallik
Copy link
Copy Markdown
Collaborator

Reverted logback downgrade and removed test.
Tested manually with mid-rest-java-demo with PR SK-EID/mid-rest-java-demo#9 changes and confirm that this log is now available in DEBUG level.

@kaidohallik kaidohallik self-requested a review April 8, 2026 10:20
@umuser umuser self-requested a review April 9, 2026 10:24
@umuser
Copy link
Copy Markdown
Collaborator

umuser commented Apr 9, 2026

demo_server_trusted_ssl_certs.jks oleks vaja ka uuendada. Uuema tsp.demo.sk.ee serdi leiab https://www.skidsolutions.eu/resources/certificates/ -> Test certificates

@umuser
Copy link
Copy Markdown
Collaborator

umuser commented Apr 9, 2026

DEMO_SERVER_CERT ee.sk.mid.integration.MobileIdSsIT klassis on ka vaja ära uuendada.

Comment thread pom.xml
<artifactId>mid-rest-java-client</artifactId>
<packaging>jar</packaging>
<version>1.3</version>
<version>1.7-SNAPSHOT</version>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelogi on ka vaja uuendada

@kaidohallik kaidohallik changed the title DDS-3046 - reduce logging level when validating user certificates Reduce logging level when validating user certificates Apr 10, 2026
@kimmo-sk kimmo-sk merged commit a60feb8 into SK-EID:master Apr 23, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reduce logging level when validating user certificates

4 participants