Skip to content

Docker Support#30

Open
samerbahri98 wants to merge 3 commits intoSAP:mainfrom
samerbahri98:main
Open

Docker Support#30
samerbahri98 wants to merge 3 commits intoSAP:mainfrom
samerbahri98:main

Conversation

@samerbahri98
Copy link
Copy Markdown

Docker support

This pull request should solve this issue
Let me know if you have any suggestions regarding the Todo section

Proposed changes

  • npm workspace to run npm commands on submodules (Since this is more like a monorepo, this should be a better approach)
  • docker-compose file to develop and test the changes locally (with the node image and postgres)
  • Dockerfile to build the asc image
  • docker-compose file to run the asc image in production
  • GitHub workflow to build and deploy the image to the GitHub Container Registry (ghcr.io)

Todo

  • Test the GitHub action workflow (requires access to the GitHub Container Registry)
  • Investigate "Found 0 matching services" bug when running in Production
  • Run the mocha tests on CI /CD (I am not sure if they require a database or they can be ran without it, I need clarification)
  • cleanup the start_application.sh script
  • Use Dockerhub alongside GitHub Container Registry (optional, requires a Dockerhub account and putting the credentials in the GitHub secrets)

Final Checklist

Please remember to do the following:

  • Search the issue repository to ensure your report is a new issue

  • Recreate the issue

  • Simplify your code around the issue to better isolate the problem

@cla-assistant
Copy link
Copy Markdown

cla-assistant bot commented Feb 6, 2023

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant