Refactor run_taxation result tuple to struct

[sfraczek]

Introduced struct TaxCalculationResult instead of large tuple returned from run_taxation

[Copilot]

Pull Request Overview

Refactors the return value of run_taxation from a large tuple into a named TaxCalculationResult struct for improved clarity and maintainability.

• Introduced TaxCalculationResult struct and updated run_taxation signature and return.
• Updated callers in main.rs and gui.rs to destructure the new struct.
• Adjusted test cases to match the new return type.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
src/lib.rs	Added TaxCalculationResult struct; changed run_taxation to return it.
src/main.rs	Updated run_taxation call and destructuring in main and tests.
src/gui.rs	Refactored GUI logic to unpack TaxCalculationResult instead of tuple.

Comments suppressed due to low confidence (3)

src/main.rs:85

• [nitpick] The variable tax_div implies it's only dividend tax, but it now represents total tax. Rename to tax or total_tax for clarity.

    let TaxCalculationResult { gross_income: gross_div, tax: tax_div, gross_sold, cost_sold, .. } = match run_taxation(&rd, pdfnames) {

src/lib.rs:249

• Public struct TaxCalculationResult lacks documentation. Add a doc comment summarizing its purpose and explaining each field.

pub struct TaxCalculationResult {

src/main.rs:312

• Tests currently only validate four fields of the struct. Consider adding assertions for the other fields (interests, transactions, etc.) to ensure they are populated correctly.

            Ok(TaxCalculationResult { gross_income: gross_div, tax: tax_div, gross_sold, cost_sold, .. }) => {

[Copilot]

[nitpick] The variable gross_div now holds total gross income (interests + dividends + revolut), which is misleading. Consider renaming it to gross_income or total_gross to reflect its new meaning.

[Copilot]

[nitpick] Add a trailing comma after the last field in the struct initializer for cleaner diffs and consistency.

Suggested change

	revolut_sold_transactions: revolut_sold_transactions})
	revolut_sold_transactions: revolut_sold_transactions,})

[jczaja]

LGTM