Fix PR #70 and Review Remaining PRs#75
Conversation
…caching - Fix signature mismatch for System::addConcentration in system.cpp - Ensure consistent use of random_open() for dt calculations in sim() and stepTo() - Correctly advance current_time to stoppingTime in stepTo() to match sim() behavior - Add regression tests for deterministic chunking in validate.py - Verified with full validation suite (58 tests pass) Co-authored-by: jrfaeder <8277248+jrfaeder@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Fixed Pull Request #70:
src/NFcore/system.cppby aligning theSystem::addConcentrationsignature with its header declaration.stepTocaching mechanism. By ensuring bothsim()andstepTo()userandom_open()for stochastic waiting-time draws and correctly advancingcurrent_timeto the chunk boundary, deterministic reproducibility is now maintained across all simulation paths.test_step_to_chunking_matches_continuous_run) and the full validation suite (all 58 tests passed).Review of remaining Pull Requests:
unistd.h. Highly recommended for cross-platform compatibility.Systemclass for library consumers. Low risk, high utility for embedders.tfunsupport. This is a high-value feature with solid documentation and regression coverage.PR created automatically by Jules for task 1616908949059018078 started by @jrfaeder