Open
Conversation
watchman.rb
Outdated
Member
There was a problem hiding this comment.
Side note --- calling gets.chomp() is fine... but the () it optional. You could just call
day = gets.chomp.capitalizeor, if it suits you:
day = gets().chomp().capitalize()It doesn't matter much -- though I recommend you pick a style and go with it for a codebase. Having devs each write differently makes code hard to understand at a glance.
Member
|
Awesome stuff! OK, last thing -- in Ruby, you can compose things very easily, like so: However, this can begin to get a little hard to read (as I'm sure you noticed). So, you can: Coffee
.all
.to_a
.select{|coffee| coffee == cof}
.each do |coffee|
puts coffe
endAll up to you on what looks best. My "rule" if its 3 or more compositions, move to a new line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Jesse,
Just completed everything...thanks for you comments, implemented them to this pull request.
Thanks,
Patil