Improve currency symbol detection

[RubenIgnacio]

Update: I recently noticed that parsing by ISO code (e.g., PEN10) has been fixed in the main branch. Therefore, this PR now focuses strictly on symbol detection (e.g., S/10), which still defaults to USD.

Expected behavior:

Monetize.parse('S/10') # <Money fractional:1000 currency:PEN>

Current behavior:

Monetize.parse('S/10') # <Money fractional:1000 currency:USD>

Proposed Solution

I implemented a manual registration strategy via register_currency_symbol.

Why not auto-load all symbols?
I discarded the initial proposal (auto-loading from Money::Currency.table) because:

1. Conflicts: Many symbols clash with decimal marks or suffixes (e.g., "K").
2. Inefficiency: Trying to list and "ignore" every problematic symbol proved to be laborious and hard to maintain.
3. Control: Since ISO codes are already loaded, it is more efficient to explicitly register only the symbols needed rather than loading the entire table with potential edge cases.

Usage:

Monetize.register_currency_symbol("S/", "PEN")

Monetize.parse("S/19.90") # <Money fractional:1990 currency:PEN>

[semmons99]

we are having an issue with CI being automatically run. if someone figures it out, or we get to it ourselves, we can merge this (and all other PRs) right away.

[RubenIgnacio]

what's the issue with the CI? maybe I can help

[semmons99]

the workflows all stopped being detected. no tests are running across any repo

[RubenIgnacio]

i just did a test and the workflow ran okay. i understand that for PRs coming from forks for the first time, it requires reviewer approval before running workflow tests. could that be the issue you're encountering, or do you have another workflow problem?

[semmons99]

Nope. It used to work. Now when I authorize it just runs code climate and not the full CI pipeline. Happy to grant repo access to the org if you would like to dive in. Cheers. 🤘SE

…

On Mon, Apr 28, 2025 at 2:09 PM, RubenIgnacio < ***@***.*** > wrote: *RubenIgnacio* left a comment (RubyMoney/ monetize#185) ( #185 (comment) ) i just did a test and the workflow ran okay. i understand that for PRs coming from forks for the first time, it requires reviewer approval before running workflow tests. could that be the issue you're encountering, or do you have another workflow problem? — Reply to this email directly, view it on GitHub ( #185 (comment) ) , or unsubscribe ( https://github.com/notifications/unsubscribe-auth/AAAGYHYI3BRUFUL2GIE2ICL23ZVEPAVCNFSM6AAAAABV3IIG2SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMZWGA3TINZSGE ). You are receiving this because you commented. Message ID: <RubyMoney/monetize/pull/185/c2836074721 @ github. com>

[RubenIgnacio]

sure, I can take a look

[semmons99]

@RubenIgnacio you are now an owner, though I think I may have fixed them...

[RubenIgnacio]

thanks for the access. did you find the problem? we could try creating a new branch, setting up the workflow there, and sending a PR with any change to test, so we don't affect main. so far, I think it could be a GH problem, because as you mentioned, the tests are failing in all repos, and I haven't found anything strange in the config.

[semmons99]

maybe it's a image version. they have all been static for years. feel free to try anything you can think of Cheers. 🤘SE

…

On Tue, Apr 29, 2025 at 16:30, RubenIgnacio < ***@***.*** > wrote: *RubenIgnacio* left a comment (RubyMoney/monetize#185) ( #185 (comment) ) thanks for the access. did you find the problem? we could try creating a new branch, setting up the workflow there, and sending a PR with any change to test, so we don't affect main. so far, I think it could be a GH problem, because as you mentioned, the tests are failing in all repos, and I haven't found anything strange in the config. — Reply to this email directly, view it on GitHub ( #185 (comment) ) , or unsubscribe ( https://github.com/notifications/unsubscribe-auth/AAAGYH4XONVYRDJ2MF3KWJT2374SDAVCNFSM6AAAAABV3IIG2SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNBQGM4DANRTGA ). You are receiving this because you commented. Message ID: <RubyMoney/monetize/pull/185/c2840380630 @ github. com>

[RubenIgnacio]

@semmons99 Hi, I tested in another branch with a friend and the CI works. I think now we just need to be careful if it happens again.