Support for theme colors and native Apple style appearance#4
Support for theme colors and native Apple style appearance#4MLabs-code wants to merge 18 commits into
Conversation
add overrideUserInterfaceStyle
overrideUserInterfaceStyle
Changed to an adaptive blur style
Update to adaptive colors
Adaptive colors
wrong commit overrideUserInterfaceStyle
By default scale none
Separator height update likely to apple native
Font size like to apple natvie
wrong commit
change font size for likely apple native
change icon size to apple likely natvie menu
adjustments needed for appearance similar to native context menu
remove weak I initialize the view that I need to display only for that component. I don't use it statically for all messages in the conversation.
on the new window it is necessary to present the screen with emoji
thibauddavid
left a comment
thibauddavid
left a comment
There was a problem hiding this comment.
Thanks for your PR ! I added a few remarks on it, let's talk about it 👍
| } | ||
| } | ||
|
|
||
| func present(_ viewControllerToPresent: UIViewController, animated flag: Bool, completion: (() -> Void)? = nil) { |
There was a problem hiding this comment.
More related to your project than this lib I think ?
| animated flag: Bool, | ||
| completion: (() -> Void)? = nil) | ||
| { | ||
| ContextMenuInteractor.shared.present(viewControllerToPresent, animated: flag, completion: completion) |
There was a problem hiding this comment.
I don't think it's relevant to add this on the library itself.
| /// If your view conforms to `ContextMenuAnimatable`, then | ||
| /// provided animations will be used to show/hide view | ||
| weak var accessoryView: UIView? | ||
| let accessoryView: UIView? |
There was a problem hiding this comment.
What is the motivation behind this ?
|
|
||
| public init( | ||
| transform: CGAffineTransform = .init(scaleX: 1.2, y: 1.2), | ||
| transform: CGAffineTransform = .identity, |
There was a problem hiding this comment.
Native style does apply a transform I think.
However I agree that it isn't as big as it was when I implemented that library. What about reducing it (yeah, 1.2 is way too much on current iOS version) instead of removing it entirely ?
Example of a specific use
| { | ||
| "identity" : "elegant-emoji-picker", | ||
| "kind" : "remoteSourceControl", | ||
| "location" : "https://github.com/Finalet/Elegant-Emoji-Picker", |
There was a problem hiding this comment.
I think a simple stackView inside a view with rounded borders would be enough as an example. We don't need to import a library for this
|
Thanks for your changes. Can you remove the |
|
Hey, any news on this ? |
It's not clear to me what all you want me to remove. |
|
Sure, it's written in above comments, but here is a synthesis:
weak var accessoryView: UIView?
let accessoryView: UIView?
public static func present(_ viewControllerToPresent: UIViewController,
animated flag: Bool,
completion: (() -> Void)? = nil)
transform: CGAffineTransform = .init(scaleX: 1.2, y: 1.2),
transform: CGAffineTransform = .identity, |
2 participants
Adjustments needed for appearance similar to native context menu