Skip to content

[Refactor] Consolidate integration tool approval waits - #3389

Open
roomote-roomote[bot] wants to merge 1 commit into
developfrom
refactor/integration-approval-wait-1jtrvyf03lnoz
Open

roomote-roomote[bot] wants to merge 1 commit into
developfrom
refactor/integration-approval-wait-1jtrvyf03lnoz

Conversation

@roomote-roomote

Copy link
Copy Markdown
Contributor

​Created by Roomote. View the task or mention @roomote-roomote for follow-up asks.

What changed

  • Added one SDK approval-wait contract for polling cadence, terminal status classification, deadlines, cancellation, and optional one-shot claiming.
  • Moved the API fallback, worker relay, and Fast session bridge onto that contract while keeping request creation, claims, notifications, and runtime replies at their existing boundaries.
  • Added focused lifecycle coverage for rejection and invalid terminal states, expiry, abort timing, and approval consumption.

Why this change was made

The three integration approval runtimes had independently accumulated the same wait state machine. Centralizing the shared lifecycle prevents timeout, abort, and terminal-status behavior from drifting while leaving security-sensitive runtime ownership explicit.

Impact

There is no intended user-facing behavior change. Integration tool approvals keep failing closed and remain one-use, with a smaller lifecycle surface for future fixes.

@roomote-community

roomote-community Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

No code issues found. See task

Reviewed d6e162b

@roomote-roomote
roomote-roomote Bot marked this pull request as ready for review October 3, 2026 10:32

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant