[Fix] Recognize more credential shapes before Auto assesses a call - #3388
Merged
Merged
Conversation
The check that asks a person whenever a credential appears in a tool call knew OpenAI, GitHub, Slack and AWS shapes. A Stripe live key (sk_live_...) did not match, so a post carrying one was left to the model and could run. The check now also knows Stripe, GitLab, Google, npm, SendGrid, Linear and Hugging Face keys, and the remaining GitHub and Slack token kinds.
Contributor
![roomote-community[bot]](https://avatars.githubusercontent.com/u/211522643?s=60&v=4){kind=small}
Stripe organization API keys start with sk_org_, which the new Stripe shape did not cover.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Auto asks a person whenever a credential appears in a tool call, using a list of known key shapes. A Stripe live key was not on the list, so a post carrying one was left to the model and could run.
What
The list now also covers Stripe, GitLab, Google, npm, SendGrid, Linear and Hugging Face keys, and the remaining GitHub and Slack token kinds. The same list masks these values on approval cards and in what the model is shown.
How to test
Unit tests cover each shape and words that only share a prefix.