[Improve] Tell Auto who the session owner is - #3383
Merged
Merged
Conversation
Auto was never told who the owner is, so it could not tell a call that names them from one that names somebody else. A plan that said "assign it to you" followed by a call naming the owner asked needlessly, and a call naming a teammate where the owner said "me" could run. Auto is now given the owner's name and email when the owner wrote every message in the session, and code marks which argument values are exactly that name or email, so a look-alike is never taken for the owner. A session other people wrote in is judged as before.
Contributor
Only the recent task prompts were checked, so an earlier prompt from somebody else stopped counting once it left the history and the owner could be named in a shared task. Senders are now checked over all of the task's prompts, as they already were for the session.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Auto compares a tool call with what the owner asked for, but it was never told who the owner is. Two things followed:
What
How to test
Unit tests cover the sender check, the exact match, and both call paths.