[Fix] Fast personalization changes when users update preferences mid-conversation - #2524
Merged
Merged
Conversation
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
September 11, 2026 13:46
Contributor
brunobergher
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why this change was made
This is a follow-up to #2482. Reloading personalization on every Fast turn changed the system prompt after learned preferences or settings edits, invalidating the provider's reusable prompt prefix. Stable per-participant snapshots preserve that cacheable prefix while retaining current-speaker adaptation and original-requester precedence.
Impact
Fast conversations now keep each speaker's system-prompt personalization stable, including when a shared thread switches away and back to that speaker. New conversations receive the latest saved profile.
Snapshots are stored in a dedicated encrypted table keyed by conversation and user. They are not added to shared conversation, Session, task, or transcript metadata; exact participant scoping prevents one speaker from receiving another speaker's private note, and canonical and compatibility transcript writes remain scrubbed. Fast preference writes use that persisted pair as the authority rather than trusting a caller-provided learning flag. Standard task start/resume behavior is unchanged because it already assembles private context at the run boundary and continues applying live opt-out.
Focused database, Fast service, shared prompt, and standard-task personalization tests pass. Repository lint, fast type checks, Knip, docs validation, broken-link checks, and diff checks also pass.