[Fix] Independent Slack suggestions share one execution thread - #2449
Merged
brunobergher merged 2 commits intoSep 10, 2026
Merged
Conversation
Contributor
|
No code issues found. See task
Reviewed 7d1ba6e |
Contributor
Author
|
Addressing both retry-safety findings on the existing PR branch: idempotent eyes acknowledgement and ownership-fenced execution-root cleanup. |
brunobergher
marked this pull request as ready for review
September 10, 2026 10:10
brunobergher
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
September 10, 2026 10:10
brunobergher
approved these changes
Sep 10, 2026
brunobergher
deleted the
fix/slack-suggestion-thread-isolation-23j7ati00q1ek
branch
September 10, 2026 12:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
already_reactedresponse is treated as idempotent success, while other acknowledgement failures still stop the launch.Why this change was made
Independent suggestions from one automation report could be accepted into the same Slack thread and Session. That mixed unrelated task history and allowed mutable routing for one task to affect announcements, progress, completion, and follow-up messages for another. Retry races also needed explicit ownership fencing so recovery could not block on an existing acknowledgement or remove a newer launch's active root.
Impact
Each accepted repository-task suggestion has an isolated conversational history and a stable Slack destination for its full lifecycle. This intentionally replaces origin-thread reuse for accepted independent work while remaining compatible with the publication provenance and acknowledgement work in #2440 and #2354. The changed behavior is backend Slack routing and concurrency control, so browser proof is not applicable; focused provider-boundary tests cover the retry cases.