Skip to content

[Fix] Custom automation tasks change models when another user targets them - #2443

Merged
roomote-roomote[bot] merged 2 commits into
developfrom
fix/model-selection-task-authorization
Sep 10, 2026
Merged

[Fix] Custom automation tasks change models when another user targets them#2443
roomote-roomote[bot] merged 2 commits into
developfrom
fix/model-selection-task-authorization

Conversation

@roomote-roomote

Copy link
Copy Markdown
Contributor

​Opened on behalf of @daniel-lxs. Follow up by mentioning @roomote-roomote, in the web UI, or in Slack.

What changed

  • Require user-token model-selection updates to pass the existing database-backed task access predicate before resolving or mutating the latest run.
  • Preserve run-token task binding, custom-automation owner and admin access, and ordinary deployment-wide task access.
  • Add real-database regression coverage for cross-user denial without persistence or sandbox restart, plus owner, admin, ordinary-task, and live-apply recovery behavior.

Why this change was made

A user token could previously target a known custom-automation task ID owned by another member and change its persisted model settings, potentially restarting its live harness. The web mutation already enforced the restrictive task-access path, but the agent-facing API only checked that some user context existed.

Impact

Unauthorized members now receive a not-found response before any run lookup, model-setting persistence, or sandbox RPC. Focused real-database coverage, the full API suite, repository type checks and lint, and the pre-push checks pass; browser proof is not applicable to this server-side authorization invariant.

@roomote-community

roomote-community Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

No code issues found. See task

Reviewed 3f9f6c3

@roomote-roomote
roomote-roomote Bot marked this pull request as ready for review September 10, 2026 05:38
@roomote-roomote
roomote-roomote Bot merged commit 48e682d into develop Sep 10, 2026
17 checks passed
@roomote-roomote
roomote-roomote Bot deleted the fix/model-selection-task-authorization branch September 10, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant