[Refactor] Use the MCP SDK for native GitLab tools - #2429
Draft
roomote-roomote[bot] wants to merge 1 commit into
Draft
[Refactor] Use the MCP SDK for native GitLab tools#2429roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
| function safeToolResult(payload: unknown, secrets: Array<string | null>) { | ||
| const text = JSON.stringify(payload); | ||
| const result = { content: [{ type: 'text' as const, text }] }; | ||
| const envelope = JSON.stringify({ jsonrpc: '2.0', id: null, result }); |
Contributor
There was a problem hiding this comment.
safeToolResult calculates the response ceiling with id: null, but the streamable transport serializes the client-supplied JSON-RPC ID into the actual response. A valid ~60 KiB string ID within the 64 KiB request limit plus a result that reaches this 1 MiB check produces a response over 1.1 MiB. Preserve the output fence by accounting for the real ID or reserving the maximum possible request-ID overhead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why this change was made
The native GitLab integration introduced in #2382 duplicated protocol behavior already owned by the MCP SDK. Keeping a second local protocol stack increased drift risk and mixed transport concerns with provider authorization and operations.
Impact
There is no intended user-facing behavior change. GitLab tools retain their repository and OAuth boundaries, operation timeout, pagination and file limits, ownership checks, credential suppression, redirect refusal, request size limit, and output fence while protocol semantics now follow the same SDK-backed pattern as neighboring integrations.