[Fix] Slack threads show duplicate review action buttons - #2421
Draft
roomote-roomote[bot] wants to merge 2 commits into
Draft
[Fix] Slack threads show duplicate review action buttons#2421roomote-roomote[bot] wants to merge 2 commits into
roomote-roomote[bot] wants to merge 2 commits into
Conversation
Contributor
Contributor
Author
|
Fixed both Slack retirement races in f67d0ed. Canonical and legacy offers now share one thread fence and choose the visible winner by posted Slack timestamp; focused database, SDK, Fast-parent, and BullMQ tests pass. Both review threads are resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why this change was made
Slack threads could accumulate multiple identical review action sets because existing retirement keys were narrower than the user-visible conversation. Independent canonical and legacy retirement also allowed attachment timing to keep the wrong controls or leave both stores live.
Impact
Each Slack thread now has one current review action set selected by visible post order, including during canonical/legacy races and delayed attachments. The surviving controls remain bound to their original task and pull-request target, while separate workspaces, threads, and non-Slack providers remain isolated.