fix: discover wan_va package for installation#90
Open
Travor278 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the setuptools package discovery configuration so editable and regular installs discover the actual
wan_vapackage tree.This keeps the published project name (
LingBot_VA) unchanged while fixing the Python package path used during build metadata generation. Existing source-tree imports such aspython -m wan_va...continue to use the same module path.Related Issue
No dedicated issue found. This was reproducible from the current
mainbranch during install smoke testing.Motivation and Context
pyproject.tomlcurrently listspackages = ["lingbot_va"], but the repository containswan_va/. As a result,pip install -e . --no-deps --dry-runfails before dependency installation with:Using setuptools package discovery for
wan_va*makes the install metadata match the repository layout and includes subpackages underwan_va.How Has This Been / Can This Be Tested?
Environment: WSL2 Ubuntu2204, Python 3.10.12 venv at
/home/Travor/venvs/starvla-332.python -m pip install -e . --no-deps --dry-runResult:
Also ran:
Checklist
wan_vaand nestedwan_va.*packages.