feat: add structured error codes to server error frames#210
Open
almuslavish wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #179
Update Complete
✅ Added src/errors.js exporting:
INVALID_JSON
VALIDATION_ERROR
RATE_LIMITED
ROOM_FULL
AUTH_FAILED
✅ Updated src/server.js:
Added sendError(ws, message, code) helper
Error frames now include payload: { message, code }
Validation failures now send code from validateMessage
✅ Updated src/validator.js:
Returns code: INVALID_JSON for malformed JSON
Returns code: VALIDATION_ERROR for schema and freshness failures
✅ Updated tests/server.test.js:
Added imports for error constants
Asserted error frames include code
Added a malformed payload validation error test
✅ Updated README.md:
Documented server-to-client error frame payload
Listed supported error codes
No lint or syntax errors were reported in the edited files.