feat: Add optional maxRoomSize to prevent room flooding#201
Open
Emelie-Dev wants to merge 1 commit into
Open
Conversation
Contributor
|
@Emelie-Dev Resolve your conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR defends against room flooding by introducing a configurable MAX_ROOM_SIZE environmental boundary.
Changes
Room Capacity: The RoomManager now respects an optional maxRoomSize setting.
Server Handlers: If a join_room message results in a rejection because the room is at capacity, the client is sent an error frame featuring a ROOM_FULL code.
Environment: Documented MAX_ROOM_SIZE within README.md and added a default limit of 500 to .env.example.
Testing: Additional unit tests have been committed to ensure full-capacity rejections and standard server error framing function smoothly.
Acceptance Criteria met
RoomManager constructor gracefully accepts { maxRoomSize }.
join() rejects when at capacity ({ ok: false, reason: 'ROOM_FULL' }).
join() processes accurately when below capacity.
Server transmits a WebSocket error frame to any client whose join was rebuffed.
.env.example and README.md accurately track this parameter.
Tested under-capacity and over-capacity edge cases.
closes #173