Github Actions - Validate tvdb seasons for PRs#98
Draft
evie-lau wants to merge 17 commits into
Draft
Conversation
Contributor
Author
|
Example of action running: evie-lau#1 |
Contributor
Author
|
Considering creating a copy/modifying the script to also do the same with TMDB, but for a separate PR |
Collaborator
Would be nice |
* Update series-tvdb.en.yaml Added Series "Yu Yu Hakusho" * Update series-tmdb.en.yaml Added Series "Yu Yu Hakusho"
…xAniSync-Custom-Mappings into evie-lau-validateTvdbSeasons
…to prevent false match
Soitora
reviewed
Jan 27, 2025
Collaborator
|
I forgot, what is there missing here before it's ready? |
Contributor
Author
|
Hmm, besides a TMDB counterpart, I don't think there was anything missing. Just needs an admin to setup the TVDB API key as noted in the first comment. |
Collaborator
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add script and github actions to validate user-inputted seasons in PRs against TVDB seasons.
ie. if user specifies a season number that doesn't exist in TVDB for the show, the script will fail the build for the PR.
!!Requires settings a TVDB api key in the repo secrets for actions
Technical details
series-tvdb.en.yaml, creates atemp.yamlwith context of 20 lines before/after the change.Notes
The first step in the actions is to prevent someone from changing the python script to print the API key in the publicly viewable Github Actions log. Please let me know who to add to trusted authors.