Skip to content

Feat: Note opacity exponent setting #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nyuwaea merged 1 commit into from
May 9, 2026
Merged

Feat: Note opacity exponent setting #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions scripts/database/settings/SettingsProfile.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,12 @@ public partial class SettingsProfile
[Order]
public SettingsItem<double> NoteOpacity { get; private set; }

/// <summary>
/// Adjusts the note opacity curve, a higher value will make any sort of transparency appear more quickly
/// </summary>
[Order]
public SettingsItem<double> NoteOpacityExponent { get; private set; }

/// <summary>
/// Overrides the skin's note mesh
/// </summary>
Expand Down Expand Up @@ -589,6 +595,20 @@ public SettingsProfile()
}
};

NoteOpacityExponent = new(1.25)
{
Id = "NoteOpacityExponent",
Title = "Note Opacity Exponent",
Description = "Adjusts the note opacity curve, a higher value will make any sort of transparency appear more quickly",
Section = SettingsSection.Visual,
Slider = new()
{
Step = 0.05f,
MinValue = 1,
MaxValue = 2
}
};

NoteMesh = new("skin")
{
Id = "NoteMesh",
Expand Down
3 changes: 2 additions & 1 deletion scripts/game/LegacyRenderer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ public override void _Process(double delta)
bool pushback = LegacyRunner.CurrentAttempt.IsReplay ? LegacyRunner.CurrentAttempt.Replays[0].Pushback : settings.Pushback.Value;
float hitWindowDepth = pushback ? (float)Constants.HIT_WINDOW * ar / 1000 : 0;
float noteOpacity = (float)settings.NoteOpacity;
float noteOpacityExponent = (float)settings.NoteOpacityExponent;

if (noteOpacity > 1)
{
Expand Down Expand Up @@ -74,7 +75,7 @@ public override void _Process(double delta)
Color color = SkinManager.Instance.Skin.NoteColors[note.Index % SkinManager.Instance.Skin.NoteColors.Length];

transform.Origin = new Vector3(note.X, note.Y, -depth);
color.A = Math.Clamp(alpha * noteOpacity, 0, 1);
color.A = Math.Clamp((float)Math.Pow(alpha * noteOpacity, noteOpacityExponent), 0, 1);
Multimesh.SetInstanceTransform(j, transform);
Multimesh.SetInstanceColor(j, color);
}
Expand Down
Loading