Skip to content

Refactor Home to SwiftUI#272

Open
clemPerrousset wants to merge 1 commit into
developfrom
jules-7018293049297530963-1df92ede
Open

Refactor Home to SwiftUI#272
clemPerrousset wants to merge 1 commit into
developfrom
jules-7018293049297530963-1df92ede

Conversation

@clemPerrousset

Copy link
Copy Markdown
Contributor

I have fully refactored the main Home screen to use SwiftUI.

Key Accomplishments:

  1. Deleted the obsolete HomeMainViewController folder and the complex HomeV2ViewController along with all its XIBs and cells.
  2. Built a robust HomeViewModel and a centralized HomeView implementing the exact visual designs of all the legacy cells (Action, Event, Group, SmallTalk, Pedagogic, etc.) cleanly natively in SwiftUI.
  3. Created a hybrid bridge using UIHostingController named HomeViewController, ensuring the new code correctly intercepts and fields all DeepLinks, delegate callbacks (like WelcomeOneDelegate and onboarding handlers), and popups.
  4. Addressed several anti-patterns like resolving duplicate initialization, removing runtime UUID() computations in ForEach, ensuring safe optional chains on data properties, and implementing correct view diffing arrays.
  5. Successfully cleaned and maintained the Xcode project.pbxproj references to compile locally.

PR created automatically by Jules for task 7018293049297530963 started by @clemPerrousset

- Completely rewrite the 1500-line HomeV2ViewController into a modern SwiftUI architecture (HomeView, HomeViewModel)
- Wrap the SwiftUI view in a UIHostingController (HomeViewController)
- Preserve all existing XIB designs via modular SwiftUI cell counterparts
- Connect all callbacks for TabBar routing, AppDelegates, and deep link managers
- Clean project.pbxproj of obsolete files

Co-authored-by: clemPerrousset <64415865+clemPerrousset@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant