Skip to content

Update onboarding UI texts, buttons, and gender handling#219

Open
clemPerrousset wants to merge 1 commit into
developfrom
update-onboarding-ui-gender-and-buttons-14522611735563272698
Open

Update onboarding UI texts, buttons, and gender handling#219
clemPerrousset wants to merge 1 commit into
developfrom
update-onboarding-ui-gender-and-buttons-14522611735563272698

Conversation

@clemPerrousset

Copy link
Copy Markdown
Contributor

This PR addresses several UI and logic updates for the Onboarding and Settings flows:

  1. Gender Field Update:

    • Replaced the display label "Autre" with "Non renseigné" in the sign-up flow.
    • Updated AuthService.mapGender to correctly map "Non renseigné" (and "non renseigne") to the backend value "secret".
  2. Association Onboarding Text:

    • Updated the localized string onboard_asso_info to: "Votre association ne figure pas dans la liste ? Ajoutez-la pour continuer.".
  3. Onboarding/Settings Buttons & Spacing:

    • Refactored EnahancedOnboardingButtonCell to dynamically configure button titles based on context:
      • Settings: "Annuler" / "Valider".
      • Onboarding (Intermediate): "Terminer plus tard" / "Suivant".
      • Onboarding (Last Step): "Terminer plus tard" / "Terminer".
    • Reduced the sticky footer height constraint in EnhancedViewController from 130 to 90 for a more compact look.
  4. Association Presentation UI:

    • Updated the title to "Présentez votre association à la communauté" and the subtitle.
    • Updated the "Description de votre association" label font to use Quicksand-Bold size 16.

PR created automatically by Jules for task 14522611735563272698 started by @clemPerrousset

- Change gender "Autre" to "Non renseigné" in `OnboardingPhase1ViewController` and update `AuthService` to map it to "secret".
- Update Association onboarding text in `Localizable.strings` (French).
- Update Association presentation title/subtitle and description font in `EnhancedViewController` and `AssociationPresentationCell`.
- Refactor `EnahancedOnboardingButtonCell` to support "Settings" (Annuler/Valider) vs "Onboarding" (Later/Next/Finish) modes.
- Reduce footer spacing in `EnhancedViewController`.

Co-authored-by: clemPerrousset <64415865+clemPerrousset@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant