Feature/fw overflow safety #642#710
Merged
Baskarayelu merged 2 commits intoJun 3, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR mitigates a critical Denial-of-Service (DoS) and incorrect accounting vector within the
family_walletcrate by replacing potential panicking/silently-saturating raw integer addition with explicit overflow-safe logic.Changes
validate_precision_spending_internalandrecord_precision_spendingto utilizechecked_addwith proper error mapping back toError::InvalidSpendingLimit. This shields accumulation logic involvingSpendingTrackerandPrecisionSpendingLimitpaths from exploitation using hostile boundary amounts.test_precision_spending_overflow_gracefultofamily_wallet/src/test.rsensuring extreme values neari128::MAXtrigger graceful errors rather than full transaction abort panics.docs/fw-overflow-safety.md.Closes #642