Skip to content

fix: correct buffer size in archiveSnapshot#655

Open
Qian-Cheng-nju wants to merge 2 commits into
RedisLabs:masterfrom
specula-org:fix/archive-snapshot-buffer-size
Open

fix: correct buffer size in archiveSnapshot#655
Qian-Cheng-nju wants to merge 2 commits into
RedisLabs:masterfrom
specula-org:fix/archive-snapshot-buffer-size

Conversation

@Qian-Cheng-nju
Copy link
Copy Markdown

@Qian-Cheng-nju Qian-Cheng-nju commented Mar 25, 2026

Hi!

I found a small buffer sizing issue in archiveSnapshot() and put together a fix.

The backup filename buffer is allocated with strlen(rdb_filename) bytes, but snprintf writes "%s.bak.%d" which needs extra space for ".bak." and the node ID. This truncates the filename on every call (e.g. "redisraft.rdb" becomes "redisraft.rd"), so rename() targets the wrong path and snapshot backups are silently lost.

The fix allocates enough space for the suffix.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jit-ci
Copy link
Copy Markdown

jit-ci Bot commented Mar 25, 2026

Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset.

In case there are security findings, they will be communicated to you as a comment inside the PR.

Hope you’ll enjoy using Jit.

Questions? Comments? Want to learn more? Get in touch with us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants