Skip to content

uv lock:Update the wrapper version in the project#5127

Merged
myakove merged 5 commits into
RedHatQE:mainfrom
acinko-rh:update-wrapper-version
Jun 9, 2026
Merged

uv lock:Update the wrapper version in the project#5127
myakove merged 5 commits into
RedHatQE:mainfrom
acinko-rh:update-wrapper-version

Conversation

@acinko-rh

@acinko-rh acinko-rh commented Jun 4, 2026

Copy link
Copy Markdown
Contributor
What this PR does / why we need it:

This is update of the wrapper version for #4780 Automation of predictable names for PVC/DV after snapshot restore

Which issue(s) this PR fixes:

#4780

Special notes for reviewer:
jira-ticket:

Summary by CodeRabbit

  • Chores
    • Updated the OpenShift Python wrapper dependency to a pinned minimum version (now >=11.0.131). This change standardizes the package requirement across installations and reduces variation in runtime behavior caused by differing dependency ranges.

@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@coderabbitai

coderabbitai Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: ac7fd3fa-1868-4b66-aa6e-d9429f928fe4

📥 Commits

Reviewing files that changed from the base of the PR and between a3a2e64 and 1b56cab.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pyproject.toml
📜 Recent review details
🧰 Additional context used
📓 Path-based instructions (1)
**

⚙️ CodeRabbit configuration file

**: ## PR Template Validation
Check the PR description for required sections from .github/pull_request_template.md.
Required sections (must be present, even if empty):

  • ##### What this PR does / why we need it: — MUST be present AND have meaningful content.
    Flag as HIGH if the section is missing, empty, whitespace-only, contains only HTML comments,
    or contains only placeholder tokens such as TBD, TBA, N/A, -, , none, or ..
  • ##### Which issue(s) this PR fixes: — must be present (may be empty)
  • ##### Special notes for reviewer: — must be present (may be empty)
  • ##### jira-ticket: — must be present (may be empty)
    If any required section is absent, or What this PR does / why we need it: has no content,
    flag it as HIGH severity and ask the author to restore the missing template section(s).

Approval Policy

You may approve the PR when ALL of the following are true:

  • All your review comments have been addressed with either:
    • a code/doc change that fixes the issue, or
    • a substantive author response that justifies no code change.
      Thread "resolved" state alone is not sufficient.
      OR you had no review comments.
  • If you posted a test execution plan comment requesting tests, and the PR author replied
    with a comment explaining why the requested tests are not needed or were already covered,
    treat that as an acceptable response — do not block approval on the test plan alone.
  • The author's explanation must be reasonable and specific (not just "N/A" or "not needed").
    Accept explanations like: "these tests were already run in CI", "this change is docs-only",
    "the affected tests are quarantined", or "verified manually on cluster X".

Files:

  • pyproject.toml

⚙️ CodeRabbit configuration file

**: # AI Review and Development Standards

Assisted-by: Claude noreply@anthropic.com

Coding standards, conventions, and review guidelines for openshift-virtualization-tests.

These rules apply to ALL contributors and review tools — human and AI alike.

Strict Rules (MANDATORY)

Linter Suppressions PROHIBITED

  • NEVER add # noqa, # type: ignore, # pylint: disable
  • NEVER disable linter/mypy rules to work around issues
  • FIX THE CODE - If linter complains, the code is wrong
  • If you think a rule is wrong: ASK the user for explicit approval

Code Reuse (Search-First Development)

Before writing ANY new code:

  1. SEARCH codebase for existing implementations
  2. CHECK utilities/ for shared functions
  3. CHECK libs/ for shared libraries
  4. CHECK tests/ for shared fixtures and helper functions
  5. CHECK pyproject.toml dependencies — project packages (e.g., pyhelper-utils, ocp-resources, openshift-python-wrapper) may already provide the functionality
  6. VERIFY no similar logic exists elsewhere
  7. NEVER duplicate logic - extract to shared module
  8. REUSE existing code and patterns — only write new when nothing exists

External package examples:

  • Shell commands — use pyhelper_utils.shell.run_command, NEVER use subprocess.run directly in test/utility code
  • OpenShift resources — use ocp-resources classes, NEVER construct raw YAML dicts

Python Requirements

  • Type hints MANDATORY - mypy strict mode in libs/, all new public functions under utilities MUST be typed
  • Use TYPE_CHECKING for type-only imports - wrap imports needed solely for type hints in if TYPE_CHECKING: to avoid runtime overhead and circular imports
  • Google-format docstrings REQUIRED - for all public functions with non-obvious return values OR side effects
  • No defensive programming - fail-fast, don't hide bugs with fake defaults (see exceptions below)
  • ALWAYS use uv run -...

Files:

  • pyproject.toml
🔇 Additional comments (1)
pyproject.toml (1)

121-121: LGTM!


📝 Walkthrough

Walkthrough

The openshift-python-wrapper dependency constraint in pyproject.toml is updated from >=11.0.128 to >=11.0.131 in the [project].dependencies list.

Changes

Dependency Version Pin

Layer / File(s) Summary
openshift-python-wrapper version pin
pyproject.toml
The openshift-python-wrapper dependency is changed from >=11.0.128 to >=11.0.131 in [project].dependencies.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • dshchedr
  • rnetser
  • RoniKishner
  • vsibirsk
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed Title clearly describes the change (wrapper version update), is under 120 characters, and accurately summarizes the main modification to pyproject.toml.
Description check ✅ Passed Description includes all required template sections with substantive content, explaining why the wrapper version update is needed (linked automation PR) and providing context for reviewers.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stp Link Required ✅ Passed No new test files or test functions added. PR only updates pyproject.toml dependency version, which is not subject to STP link requirement.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Linked repositories: Your configuration references 1 linked repositories, but your current plan allows 0. Analyzed ``, skipped RedHatQE/openshift-virtualization-tests-design-docs.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Jun 4, 2026
@acinko-rh acinko-rh force-pushed the update-wrapper-version branch from 70659dc to b6c0d07 Compare June 4, 2026 12:46
@acinko-rh acinko-rh changed the title [Storage] update the wrapper version in the project Update the wrapper version in the project Jun 4, 2026
@acinko-rh acinko-rh changed the title Update the wrapper version in the project uv lock:Update the wrapper version in the project Jun 4, 2026
@acinko-rh

Copy link
Copy Markdown
Contributor Author

/build-and-push-container

@openshift-virtualization-qe-bot-6

Copy link
Copy Markdown

New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-5127 published

@ema-aka-young ema-aka-young left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should bump the version in the pyproject as well

@openshift-virtualization-qe-bot-2

Copy link
Copy Markdown
Contributor

Clean rebase detected — no code changes compared to previous head (dde8ff1).

@acinko-rh

Copy link
Copy Markdown
Contributor Author

@ema-aka-young bumped the patch version

acinko-rh and others added 3 commits June 9, 2026 10:24
Signed-off-by: Adam Cinko <acinko@redhat.com>
Co-authored-by: Emanuele Prella <eprella@redhat.com>
Signed-off-by: Adam Cinko <acinko@redhat.com>
Co-authored-by: Emanuele Prella <eprella@redhat.com>
Signed-off-by: Adam Cinko <acinko@redhat.com>
@openshift-virtualization-qe-bot-3

Copy link
Copy Markdown
Contributor

Clean rebase detected — no code changes compared to previous head (e545cba).

@acinko-rh

Copy link
Copy Markdown
Contributor Author

/build-and-push-container

vsibirsk
vsibirsk previously approved these changes Jun 9, 2026
@openshift-virtualization-qe-bot

Copy link
Copy Markdown

New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-5127 published

Comment thread uv.lock
Signed-off-by: Adam Cinko <acinko@redhat.com>
coderabbitai[bot]
coderabbitai Bot previously approved these changes Jun 9, 2026
@acinko-rh

Copy link
Copy Markdown
Contributor Author

/build-and-push-container

@openshift-virtualization-qe-bot

Copy link
Copy Markdown

Clean rebase detected — no code changes compared to previous head (1b56cab).
The following labels were preserved: lgtm-jpeimer, lgtm-coderabbitai[bot].

@openshift-virtualization-qe-bot-2

Copy link
Copy Markdown
Contributor

New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-5127 published

@myakove

myakove commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

/lgtm
/approve

@acinko-rh

Copy link
Copy Markdown
Contributor Author

/verified
test-pytest-cnv-4.22-smoke/2
-s -o log_cli=true -o cache_dir=/tmp/cache-pytest --storage-class-matrix=ocs-storagecluster-ceph-rbd-virtualization

@openshift-virtualization-qe-bot-3

Copy link
Copy Markdown
Contributor

@coderabbitai

Test execution plan request details

CRITICAL: You MUST post an inline review comment on the first changed line of the first file.
The inline comment should contain the full Test Execution Plan (smoke decision, gating decision, and specific affected tests).
Do NOT submit a blocking review event (REQUEST_CHANGES/APPROVE).
Post a single inline PR comment on Files Changed (non-blocking COMMENT flow).

As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan.
You will post an inline review comment with the test execution plan on the first changed file.
If you fail to run or post a comment, retry.

Analysis Requirements:

  1. Examine code changes in each modified file

  2. Identify affected code paths, functions, and classes

  3. Analyze pytest-specific elements: fixtures (scope, dependencies), parametrization, markers, conftest changes

  4. Trace test dependencies through imports, shared utilities, fixture inheritance, fixture teardown, and yield from cleanup in conftest

  5. Detect new tests introduced in the PR

  6. Utilities and libs impact (when utilities/ or libs/ changes):
    You MUST use shell scripts (rg, git diff) to trace the full impact.
    Follow these sub-steps in order:

    6a. Identify modified symbols: For each changed file under utilities/ or libs/,
    list every modified function or method.
    Example: git diff HEAD~1 --unified=0 -- utilities/hco.py | grep '^[+-]def '

    6b. Find direct callers: Search tests and conftest for each symbol from 6a.
    Example: rg -l 'get_hco_version' tests/

    6c. Trace fixture teardown and cleanup: Find fixtures that reach
    the modified symbol through yield from or context-manager wrappers.
    Example: rg -l 'yield from.*enable_common_boot|def.*enable_common_boot' tests/

    6d. Trace same-file callers: In each changed file, find other functions
    whose body calls a modified symbol (including code after yield
    in @contextmanager helpers).
    Example: rg 'get_hco_version|enable_common_boot' utilities/hco.py

    6e. Expand transitively: If function A calls modified B, then
    tests/fixtures that call A are affected — even when the test body
    never imports B directly.

    Do NOT limit impact to tests that import the modified symbol only.

  7. Smoke test impact: Intersect the affected set from step 6 with smoke-marked tests.
    Run: rg -l '@pytest.mark.smoke' tests/
    VERIFY the above command returned actual file paths before concluding False.
    Set True if either condition is met:

    • a smoke-marked file appears in the affected set from 6b-6e, OR
    • any conftest.py in the smoke test's parent-directory hierarchy (up to repo root)
      imports or calls a modified utilities/libs symbol — including autouse fixtures
      that depend on modified functions. ALL tests in that directory and below are affected.
      Example check: for each smoke_file, scan dirname(smoke_file)/conftest.py,
      dirname(dirname(smoke_file))/conftest.py, etc. for modified symbol imports
      and autouse fixtures that depend on modified symbols.
  8. Gating test impact: Intersect the affected set from step 6 with gating-marked tests.
    Run: rg -l '@pytest.mark.gating' tests/
    Set True if a gating-marked file also appears in the affected set from 6b-6e.
    Utilities/libs changes often affect gating tests without affecting smoke tests.
    Do NOT stop analysis after concluding Run smoke tests: False.

Output rules:
Do NOT include analysis step numbers (1-8) in your visible output.

Your deliverable:
Your inline informational comment will be based on the following requirements:

Test Execution Plan

  • Run smoke tests: True / False — If True, state the dependency path (test → fixture → changed symbol). True ONLY with a verified path.
  • Run gating tests: True / False — If True, state the dependency path. True if any gating-marked test is in the affected set.
  • Affected tests to run (required when utilities/, libs/, or shared conftest changes — list concrete paths even when smoke is False)

Use these formats:

  • path/to/test_file.py - When the entire test file needs verification
  • path/to/test_file.py::TestClass::test_method - When specific test(s) needed
  • path/to/test_file.py::test_function - When specific test(s) needed
  • -m marker - When a marker covers multiple affected tests (e.g. -m gating only if ALL gating tests in scope need run)
  • Tag each listed test or group with its marker when not obvious, e.g. (gating) or (smoke)

Real test commands (MANDATORY when changes affect session/runtime code):

When the affected code runs at session/collection time (conftest fixtures, pytest plugins,
config hooks, session-scoped setup) or modifies runtime behavior that unit tests mock away,
you MUST include concrete pytest commands the PR author must run on a real cluster
to verify the change works end-to-end. Include:

  • A command for the error/fix path (the scenario the PR fixes)
  • A command for the happy path (regression: the normal case still works)
  • Use lightweight tests (e.g., --collect-only for startup failures,
    a single small test for runtime behavior)
    If the PR only changes test logic (not utilities/libs/conftest), the affected test
    paths themselves serve as the real test commands — no separate section needed.

Example output for a session-startup fix:

**Real tests (cluster required)**
Error path (the fix):
`pytest tests/storage/.../test_foo.py --storage-class-matrix=nonexistent-sc --collect-only`
Expected: ValueError with clear message, not IndexError

Happy path (regression):
`pytest tests/storage/.../test_foo.py --storage-class-matrix=<valid-sc> -k test_bar`
Expected: session starts normally

Guidelines:

  • Include tests affected directly OR via fixture setup/teardown, yield from cleanup, or transitive utility call chains (caller calls modified helper)
  • Use a full file path only if ALL tests in that file require verification
  • Use file path + test name when only specific tests use an affected fixture or utility wrapper (preferred for partial file impact)
  • If a test marker can cover multiple files/tests, provide the marker
  • Balance coverage vs over-testing - Keep descriptions minimal
  • Example: if leaf helper foo() changes, include tests whose fixture teardown calls wrapper bar() where bar() calls foo(), even when the test body only imports an unrelated symbol from the same utilities module

Hardware-Related Checks (SR-IOV, GPU, DPDK):

When PR modifies fixtures for hardware-specific resources:

  • Collection Safety: Fixtures MUST have existence checks (return None when hardware unavailable)
  • Test Plan: MUST verify both WITH and WITHOUT hardware:
    • Run affected tests on cluster WITH hardware
    • Verify collection succeeds on cluster WITHOUT hardware

CRITICAL WORKFLOW COMPLETION RULES:

When responding to this test execution plan request, you MUST follow these rules EXACTLY:

  1. YOUR ONLY DELIVERABLE: Post one non-blocking inline comment containing the test execution plan on the first changed line
  2. THEN STOP IMMEDIATELY - Do NOT generate any additional response
  3. FALLBACK ONLY: If inline comment API calls fail after retrying, post as a regular PR comment
  4. SILENCE = SUCCESS: After successfully submitting the review, your task is complete. No confirmation needed.

ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):

  • ❌ Do NOT post acknowledgment messages like "Test execution plan posted", "Review posted successfully", "I've successfully posted"
  • ❌ Do NOT mention review IDs, URLs, or confirmation of posting in the PR thread
  • ❌ Do NOT add any follow-up comments after submitting the review
  • ❌ Do NOT reply to confirm task completion
  • ❌ Do NOT explain what you did - just do it and stop

Remember: The pull request review is visible to users. Additional comments are redundant noise.

CRITICAL — Verification rules for smoke and gating decisions:
- For each True decision, you must have traced a concrete path: test file → fixture → utility function → modified symbol.
- Do NOT assume impact based on scope, file proximity, or infrastructure-sounding names.
Only set True when you trace a concrete path through steps 6a-6e, then 7 or 8.
WRONG: "utilities/hco.py changed → run smoke" (no traced dependency path)
WRONG: "Run smoke tests: False" with no affected-test list when gating tests use the changed utility
RIGHT: "Run smoke tests: False, Run gating tests: True" plus tests/.../test_foo.py::TestBar::test_baz (gating)
RIGHT: "Smoke test X uses fixture Y → wrapper Z → changed function W in utilities/hco.py"

Comment thread pyproject.toml
"python-simple-logger>=2.0.13",
"pytest-html>=4.1.1",
"openshift-python-wrapper>=11.0.128",
"openshift-python-wrapper>=11.0.131",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Execution Plan

  • Run smoke tests: False — This PR only bumps the openshift-python-wrapper dependency constraint from >=11.0.128 to >=11.0.131. No utilities, libs, conftest, or test files were modified. There is no traceable path from this change to any smoke-marked test.
  • Run gating tests: False — Same rationale; no code symbols changed, no dependency path to any gating-marked test.
  • Affected tests to run: None — dependency version constraint updates in pyproject.toml/uv.lock do not directly affect test logic or fixtures.

@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Get PR diff to find the first changed line in pyproject.toml
gh pr view 5127 --repo RedHatQE/openshift-virtualization-tests --json files --jq '.files'

# Get the diff to find position info
gh api repos/RedHatQE/openshift-virtualization-tests/pulls/5127/files --jq '.[] | {filename: .filename, patch: .patch}'

Length of output: 2643


🏁 Script executed:

#!/bin/bash
# Post inline review comment on the first changed line of pyproject.toml
# First get the commit SHA for the PR
PR_HEAD_SHA=$(gh api repos/RedHatQE/openshift-virtualization-tests/pulls/5127 --jq '.head.sha')
echo "HEAD SHA: $PR_HEAD_SHA"

# Get file diff to find position
gh api repos/RedHatQE/openshift-virtualization-tests/pulls/5127/files --jq '.[] | select(.filename == "pyproject.toml") | {filename: .filename, patch: .patch, sha: .sha}'

Length of output: 976


🏁 Script executed:

#!/bin/bash
# Post an inline non-blocking review comment on the first changed line of pyproject.toml
# The + line is at line 121 in the new file (position 6 in the diff)
# Using the GitHub pull request reviews API

PR_HEAD_SHA="47db12db5a82103568016e58cc4a74feb1a158d6"

gh api \
  --method POST \
  repos/RedHatQE/openshift-virtualization-tests/pulls/5127/reviews \
  --field commit_id="$PR_HEAD_SHA" \
  --field event="COMMENT" \
  --field body="" \
  --field "comments[][path]=pyproject.toml" \
  --field "comments[][line]=121" \
  --field "comments[][side]=RIGHT" \
  --field "comments[][body]=**Test Execution Plan**

- **Run smoke tests: False** — This PR only bumps the \`openshift-python-wrapper\` dependency constraint from \`>=11.0.128\` to \`>=11.0.131\`. No utilities, libs, conftest, or test files were modified. There is no traceable path from this change to any smoke-marked test.
- **Run gating tests: False** — Same rationale; no code symbols changed, no dependency path to any gating-marked test.
- **Affected tests to run:** None — dependency version constraint updates in \`pyproject.toml\`/\`uv.lock\` do not directly affect test logic or fixtures."

echo "Exit code: $?"

Length of output: 2991



@openshift-virtualization-qe-bot-3

Copy link
Copy Markdown
Contributor

Successfully removed PR tag: quay.io/openshift-cnv/openshift-virtualization-tests:pr-5127.

@openshift-virtualization-qe-bot-3

Copy link
Copy Markdown
Contributor

New container for quay.io/openshift-cnv/openshift-virtualization-tests:latest published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.