Skip to content

fix: disable rebase strategy - #1862

Merged
swadeley merged 1 commit into
RedHatInsights:masterfrom
swadeley:swadeley/disable_strict_rebase_strategy
Oct 26, 2026
Merged

swadeley merged 1 commit into
RedHatInsights:masterfrom
swadeley:swadeley/disable_strict_rebase_strategy

Conversation

@swadeley

@swadeley swadeley commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Rebasing multiple PRs at the same time is unproductive.
Associated Jira ticket: # (issue)
https://redhat.atlassian.net/browse/HMS-11478

Rebasing multiple PRs after every push to master is unproductive.
Rather rebase as required.

Checklist:

  • [x ] The commit message has the Jira ticket linked
  • [ x] PR has a short description
  • Screenshots before and after the change are added
  • Tests for the changes have been added
  • README.md is updated if necessary
  • Needs additional dependent work

@swadeley
swadeley requested a review from a team as a code owner October 26, 2026 14:09
@codecov-commenter

codecov-commenter commented Oct 26, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.36%. Comparing base (8e120be) to head (0ae4f9a).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1862   +/-   ##
=======================================
  Coverage   77.36%   77.36%           
=======================================
  Files         102      102           
  Lines        3300     3300           
  Branches      756      756           
=======================================
  Hits         2553     2553           
  Misses        668      668           
  Partials       79       79           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@swadeley swadeley removed their assignment Oct 26, 2026
Rebasing multiple PRs at the same time is unproductive.
https://redhat.atlassian.net/browse/HMS-11478
@swadeley
swadeley force-pushed the swadeley/disable_strict_rebase_strategy branch from bbaa56d to 0ae4f9a Compare October 26, 2026 14:31

@dominikvagner dominikvagner left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ✅

@swadeley
swadeley merged commit 38c96b5 into RedHatInsights:master Oct 26, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants