fix: on make docs-serve, page was constantly refreshing. Now not.#74
Open
ofSingularMind wants to merge 2 commits intomainfrom
Open
fix: on make docs-serve, page was constantly refreshing. Now not.#74ofSingularMind wants to merge 2 commits intomainfrom
ofSingularMind wants to merge 2 commits intomainfrom
Conversation
bvdmitri
reviewed
Mar 11, 2026
| ] | ||
| end | ||
|
|
||
| const ALL_EXAMPLES_CONTRIBUTING_NOTE = """ |
Member
There was a problem hiding this comment.
Should this constant also be guarded?
Contributor
Author
There was a problem hiding this comment.
:) I'm not sure. It does not cause the re-definition issue like the others.
the just in-memory check should be enough
Member
|
I removed the |
Member
|
If those |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a bug where the LiveServer preview would keep reloading as constants were redefined. If that doesn't occur for you, maybe pass. The code logic is sound and worked effectively in my case.