[codex] Merge service proof style into Radical Codes site#14
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (10)
✅ Files skipped from review due to trivial changes (4)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughThis PR introduces a comprehensive site redesign by extracting a shared dark-themed stylesheet, rebuilding the main landing page with new service sections and interactive workflow controls, and creating a new AI Rescue vertical landing page. The main site now routes CTAs to the new page. Vite is configured to output both pages as separate build artifacts. Test suites validate HTML metadata, package.json structure, and SEO discovery files. ChangesSite redesign, dual-page build, shared styling, and comprehensive test coverage
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~28 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
index.html (1)
373-380: 🧹 Nitpick | 🔵 Trivial | ⚡ Quick winComplete ARIA tab behavior or remove tab roles.
You’re declaring a tablist/tab pattern, but interaction is click-only. Add arrow-key navigation + roving
tabindex+ panel association (aria-controls/aria-labelledby), or switch to plain buttons without tab roles to avoid misleading assistive tech.Also applies to: 546-562
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@index.html` around lines 373 - 380, The workflow-controls div and its tab buttons are declaring ARIA tab roles but lack the complete tab pattern implementation. Either implement the full ARIA tab behavior by adding JavaScript to handle arrow-key navigation between the buttons, implementing roving tabindex to manage focus, and adding aria-controls attributes on the tab buttons to associate them with their corresponding workflow-demo panels, or alternatively remove the role="tablist" from the workflow-controls container and role="tab" from each button element and treat them as standard buttons with aria-selected attributes if keyboard navigation is not needed.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@styles.css`:
- Line 56: The text-rendering property value `optimizeLegibility` uses mixed
case which violates stylelint's keyword-case rule requiring all CSS keywords to
be lowercase. Change `optimizeLegibility` to `optimizelegibility` to comply with
the linting rule. Additionally, ensure that the `currentColor` keyword mentioned
in the comment (appearing at line 382) is also normalized to lowercase
`currentcolor` for consistency across the stylesheet.
- Line 127: The clip property with rect(0, 0, 0, 0) is deprecated and will cause
future breakage. Replace the deprecated clip: rect(0, 0, 0, 0); declaration with
clip-path: inset(100%); to achieve the same visually-hidden effect. You can
optionally keep the clip property as a fallback for older browsers, but
clip-path should be the primary approach used in the assistive-utility styles.
---
Nitpick comments:
In `@index.html`:
- Around line 373-380: The workflow-controls div and its tab buttons are
declaring ARIA tab roles but lack the complete tab pattern implementation.
Either implement the full ARIA tab behavior by adding JavaScript to handle
arrow-key navigation between the buttons, implementing roving tabindex to manage
focus, and adding aria-controls attributes on the tab buttons to associate them
with their corresponding workflow-demo panels, or alternatively remove the
role="tablist" from the workflow-controls container and role="tab" from each
button element and treat them as standard buttons with aria-selected attributes
if keyboard navigation is not needed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: a69c8eaf-414d-4586-9ec3-980a4ef5a5df
⛔ Files ignored due to path filters (6)
public/assets/service-proof/automarkets-live-home.pngis excluded by!**/*.pngpublic/assets/service-proof/internal-ai-admin-dashboard.pngis excluded by!**/*.pngpublic/assets/service-proof/internal-ai-workflow-output.pngis excluded by!**/*.pngpublic/assets/service-proof/mygradhub-live-mvp.pngis excluded by!**/*.pngpublic/assets/service-proof/radical-workflow-local.pngis excluded by!**/*.pngpublic/assets/service-site/reviewable-workflow-command-center.pngis excluded by!**/*.png
📒 Files selected for processing (2)
index.htmlstyles.css
Summary
check, and add rewritten Vitest contract tests for the current site instead of the old [codex] Merged Radical Codes preview #9 page modelVerification
npm testnpm run checkgit diff --checkindex.htmlandai-app-rescue/index.htmlhttp://127.0.0.1:4179/: desktop home render, proof-wall render, workflow button interaction, mobile menu interaction,/ai-app-rescue/smoke load, manifest/sitemap serving, no console warnings/errors, no horizontal overflowConsolidation notes
Summary by CodeRabbit
New Features
Improvements
Tests / Quality