Repository navigation
Require HadronicLineshapes 0.5 as a test-only dependency; drop Literate - #51
Merged
Merged
Conversation
HadronicLineshapes 0.5 makes BreitWigner, MultichannelBreitWigner and Flatte type-stable and allocation-free (mmikhasenko/HadronicLineshapes.jl#70). With it, the heterogeneous-chain benchmark drops from 34.3 to 26.3 us per point (47 -> 26 KB) and the whole model passes @inferred. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mmikhasenko
force-pushed
the
deps/hadroniclineshapes-0.5
branch
from
October 8, 2026 18:11
ef11b83 to
1112f73
Compare
Nothing in src/ loads HadronicLineshapes; only the tests (and the docs, examples and benchmark environments, which list it themselves) do. Move it to [extras]/[targets]. Literate was never loaded anywhere; remove it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mmikhasenko
marked this pull request as ready for review
October 8, 2026 18:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HadronicLineshapescompat bound from0.4.2to0.5, inProject.tomlandbenchmark/Project.toml.HadronicLineshapesa test-only dependency ([extras]/[targets]). Nothing insrc/loads it. Installing CascadeDecays no longer pulls it in; the docs, examples and benchmark environments already list it themselves.Literatedependency. It was never loaded anywhere in the repository.HadronicLineshapes 0.5.0 makes
BreitWigner,MultichannelBreitWignerandFlattetype-stable and allocation-free, which fixes mmikhasenko/HadronicLineshapes.jl#70. That was the last instability left after #50. With it, the benchmark model is fully inferred.benchmark/heterogeneous_chains.jl, 8-chain pp → p p K⁺ K⁻ model, per phase-space point:unpolarized_intensity(model, point)@inferred unpolarized_intensity(model, point)Any)The benchmark comments that described
BreitWigneras type-unstable are updated.Merge order
mainand contains a single commit.Compatibility notes
src/uses HadronicLineshapes, so it is now test-only; it's loaded by the tests, docs, examples and benchmarks. None of them use the APIs that 0.5.0 changes (MultichannelBreitWigner{N}as a concrete type, non-IntLinBlattWeisskopf{L}).docs/andexamples/have no compat entry for HadronicLineshapes and will resolve to 0.5 automatically.Test plan
318b732(v0.5.0), in a scratch environment: all 17 testsets pass.benchmark/heterogeneous_chains.jlagainst v0.5.0 (numbers above), plus@inferredon every chain and on the whole model.using CascadeDecaysloads, and neither HadronicLineshapes nor Literate is installed.Pkg.test()against the registered HadronicLineshapes v0.5.0.🤖 Generated with Claude Code