Skip to content

Merge group related improvements for convolution operations - #4296

Closed
assistant-librarian[bot] wants to merge 25 commits into
developfrom
import/develop/ROCm_composable_kernel/pr-3439
Closed

Merge group related improvements for convolution operations#4296
assistant-librarian[bot] wants to merge 25 commits into
developfrom
import/develop/ROCm_composable_kernel/pr-3439

Conversation

@assistant-librarian

@assistant-librarian assistant-librarian Bot commented Feb 3, 2026

Copy link
Copy Markdown
Contributor

A collection of several depthwise convolution related improvements.

Proposed changes

The list of todos came from the investigation of 2d convolution performance on fp32 data input. It turns out CK has limited support for merged group convolutions. The purpose of this PR is to add some of the missing functionality.

  • Added merged groups implementation for backward data convolution in 2d and 3d.
  • Added new instances for fp32 bit fwd convolution with merge group sizes 2 and 4
  • Added missing instances for fp32 wrw convolution
  • Added tuned instances bwd data convolution
  • On the miopen side removed the restriction to not use fp32 wrw instances from CK

Note: Backward data convolution type string was kept intact for NumMergeGroups == 1 for miopen compatibility.

Checklist

Please put an x into the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.

  • I have added tests relevant to the introduced functionality, and the unit tests are passing locally
  • I have added the test to REGRESSION_TESTS list defined at the top of CMakeLists.txt in tests/CMakeLists.txt, IF the test takes more than 30 seconds to run.
  • I have added inline documentation which enables the maintainers with understanding the motivation
  • I have removed the stale documentation which is no longer relevant after this pull request
  • (If this change is user-facing) I have added release notes which provide the end users with a brief summary of the improvement from this pull request
  • I have run clang-format on all changed files
  • Any dependent changes have been merged

Discussion

If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered


🔁 Imported from ROCm/composable_kernel#3439
🧑‍💻 Originally authored by @zsotakal

@zsotakal
zsotakal requested review from a team as code owners February 4, 2026 17:55
@zsotakal zsotakal self-assigned this Feb 10, 2026
@zsotakal zsotakal added the organization: streamhpc contributors from streamhpc label Feb 25, 2026
@bartekxk bartekxk closed this Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants