Merge group related improvements for convolution operations - #4296
Closed
assistant-librarian[bot] wants to merge 25 commits into
Closed
Merge group related improvements for convolution operations#4296assistant-librarian[bot] wants to merge 25 commits into
assistant-librarian[bot] wants to merge 25 commits into
Conversation
…evelop/ROCm_composable_kernel/pr-3439
assistant-librarian
Bot
requested review from
aosewski,
carlushuang,
illsilin,
poyenc and
qianfengz
as code owners
February 3, 2026 21:52
assistant-librarian
Bot
requested review from
ThomasNing,
afagaj,
andriy-ca,
asleepzzz,
bartekxk,
coderfeli,
geyyer and
tenpercent
as code owners
February 3, 2026 21:52
BradPepersAMD
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A collection of several depthwise convolution related improvements.
Proposed changes
The list of todos came from the investigation of 2d convolution performance on fp32 data input. It turns out CK has limited support for merged group convolutions. The purpose of this PR is to add some of the missing functionality.
Note: Backward data convolution type string was kept intact for
NumMergeGroups == 1for miopen compatibility.Checklist
Please put an
xinto the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.clang-formaton all changed filesDiscussion
If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered
🔁 Imported from ROCm/composable_kernel#3439
🧑💻 Originally authored by @zsotakal