Skip to content

Fix incorrect instructions for configuring groups automatically - #422

Open
ddmatsu wants to merge 1 commit into
ROCm:developfrom
ddmatsu:develop
Open

Fix incorrect instructions for configuring groups automatically#422
ddmatsu wants to merge 1 commit into
ROCm:developfrom
ddmatsu:develop

Conversation

@ddmatsu

@ddmatsu ddmatsu commented Feb 20, 2025

Copy link
Copy Markdown

Currently, only 'render' group is applied to a new user because of incorrect usage of EXTRA_GROUPS configuration.
This change ensures that users configure the both groups correctly, preventing potential misconfigurations.

EXTRA_GROUPS is space-separated list of groups.

Signed-off-by: Daisuke Matsuda <matsuda-daisuke@fujitsu.com>
@ddmatsu
ddmatsu requested a review from a team as a code owner February 20, 2025 00:27
peterjunpark pushed a commit to peterjunpark/rocm-install-on-linux that referenced this pull request Feb 20, 2025
* ROCm Offline Installer Creator 6.3.3 updates

* Clarify instructions

* Address internal review comment
@ddmatsu

ddmatsu commented Jul 25, 2025

Copy link
Copy Markdown
Author

Hi,

I noticed that the issue is still present in the latest version (v6.4.2) of the documentation.
I believe the correction is important for clarity and accuracy for ROCm users.

Are there any issues or obstacles preventing this PR from being merged?
If you need source it is written in 'man adduser.conf'

    EXTRA_GROUPS
          This is the space-separated list of groups that new non-system users will be added to.  Defaults to users.

cf. https://manpages.debian.org/testing/adduser/adduser.conf.5.en.html

Thanks,
Daisuke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant