Add hipSPARSE xcsr2coo f2003 test - #483
Merged
Merged
Conversation
Ozone-Whiskey
marked this pull request as ready for review
August 6, 2026 21:34
amontoison
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the missing Fortran 2003 test for
hipsparseXcsr2coo. The f2008 version already exists (test/f2008/hipsparse/hipsparse_xcsr2coo.f08); this fills in the f2003 tier so csr2coo matches the both-tier coverage of the other hipSPARSE conversion routines (and of rocSPARSE'scsr2coo).Follow-up to the review comment on #480 — my original hipSPARSE PR had an f2003
xcsr2coo, but it was dropped during conflict resolution when develop (#478) had independently added the f2008 one; this restores the f2003 half.What it does
Mirrors the existing f2008 test exactly (same CSR row-pointer input
[0,2,3,5], expected COO rows[0,0,1,2,2]), using the f2003 calling style:type(c_ptr)device buffers allocated by byte count, host data moved viahipMemcpy+c_loc.Test plan