Skip to content

Improve path readability check #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sjoerdsimons wants to merge 1 commit into from
Closed

Improve path readability check #176

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions amdsmi_cli/amdsmi_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1252,6 +1252,11 @@ def _has_read_access(self, path: str) -> Tuple[bool, Optional[int], Optional[str
if os.geteuid() == 0:
return True, None, None

# Use os.access to check read permission (including ACLs) without
# opening the path, to avoid potential issues with device nodes.
if os.access(path, os.R_OK):
return True, None, None

mode = st.st_mode
uid = st.st_uid
gid = st.st_gid
Expand Down
Loading