#255 refactor: move update_readme tool out of the library crate#256
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #255
reqwest(a native blocking HTTP client, pulling hyper/tokio/etc.) andregexwere declared as hard[dependencies]of the published crate but used only by theupdate_readmedev binary — so every downstream user of this WASM SDK compiled them for nothing.Changes
src/bin/update_readme/into a new non-published workspace membertools/update-readmewith its own dependencies.regexandreqwestfrom the library crate's[dependencies](both unused by the library;percent-encodingandtomlstay — used bycore::contextand themockfeature).[workspace]Cargo.tomlinstead ofCARGO_MANIFEST_DIR.cargo run -p update-readme; codecov ignorestools/**.Result
cargo tree -p telegram-webapp-sdk(default features) now pulls no reqwest / regex / hyper / tokio. Verified: tool + lib tests green (23 + 182),cargo denyok, clippy/fmt clean, README stays in sync (workspace-root resolution works),reuse lintpasses.