refactor: replace absorb fill checkboxes with dropdown in resource bar settings#984
Closed
andybergon wants to merge 1 commit into
Closed
refactor: replace absorb fill checkboxes with dropdown in resource bar settings#984andybergon wants to merge 1 commit into
andybergon wants to merge 1 commit into
Conversation
Reverse absorb fill and overfill absorb are mutually exclusive options. With two checkboxes, checking one silently unchecks the other which is easy to miss. A single dropdown makes the mutual exclusivity obvious. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
andybergon
added a commit
to andybergon/EnhanceQoL
that referenced
this pull request
Apr 22, 2026
- Flag 'Absorb text on health bar' as likely overlapping with upstream's newly-added absorbText; needs in-game audit. - PRs R41z0r#982 (right-click) and R41z0r#984 (absorb fill dropdown) still open. - persistSignUpNote taint fix kept — upstream still uses global-replacement anti-pattern. - Midnight health-bar color fix kept — upstream did not adopt.
Owner
|
Closing stale PR while cleaning up old open pull requests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Reverse absorb fill" and "Overfill absorb bar" options are mutually exclusive - enabling one disables the other. With two checkboxes, checking one silently unchecks the other, which is easy to miss. A dropdown is better UX here since it makes the mutual exclusivity obvious.
Replaces them with a single "Absorb fill mode" dropdown with three options: Normal, Reverse fill, and Overfill.
Backwards compatible - reads and writes the same
absorbReverseFill/absorbOverfillboolean fields, so existing saved settings carry over without migration.