Sync resource bar height to parent frame when set to vertical#971
Closed
brandonlee781 wants to merge 2 commits into
Closed
Sync resource bar height to parent frame when set to vertical#971brandonlee781 wants to merge 2 commits into
brandonlee781 wants to merge 2 commits into
Conversation
Owner
|
Closing stale PR while cleaning up old open pull requests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simple toggle that replicated the behavior of matching a parent frames width, but instead when the resource bar is set to vertical orientation it will match the parent frames height. Useful for vertical UIs.
Only thing I wasn't able to replicate is "real time" syncing. If a resource bar is set as a child to the cooldown manager, and if the cooldown manager is updated (icon removed or added) the bars don't adjust their height until /reload or edit mode is opened. I just couldn't figure that part out on my own.