Skip to content

Get lobby announcement from Atlas#699

Open
ASpoonPlaysGames wants to merge 11 commits into
R2Northstar:mainfrom
ASpoonPlaysGames:atlas-announcements
Open

Get lobby announcement from Atlas#699
ASpoonPlaysGames wants to merge 11 commits into
R2Northstar:mainfrom
ASpoonPlaysGames:atlas-announcements

Conversation

@ASpoonPlaysGames

@ASpoonPlaysGames ASpoonPlaysGames commented Sep 3, 2023

Copy link
Copy Markdown
Contributor

Marking as a draft because this relies on a new Atlas endpoint. (R2Northstar/Atlas#38)

Comment thread Northstar.Client/mod/scripts/vscripts/ui/_menus.nut Outdated
@github-actions github-actions Bot added the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Dec 20, 2023
@github-actions github-actions Bot removed the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Aug 29, 2024
@Alystrasz

Copy link
Copy Markdown
Member
  • How do you consider displaying this information in the lobby?
  • Do you plan on opening the Atlas PR yourself?

@ASpoonPlaysGames

Copy link
Copy Markdown
Contributor Author
  • How do you consider displaying this information in the lobby?

It's already done and has been for a while, all you need to do is set some convars to display a message. Currently we display a message about progression.

  • Do you plan on opening the Atlas PR yourself?

No, I haven't touched Go before really. It would basically be the same as mainmenupromos though, perhaps with a localisation file sent in some way as well? Idk.

The linked issue details requirements.

@github-actions github-actions Bot added the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Jan 2, 2026
pg9182 added a commit to R2Northstar/Atlas that referenced this pull request Jan 15, 2026
@pg9182

pg9182 commented Jan 15, 2026

Copy link
Copy Markdown
Member

@ASpoonPlaysGames

@ASpoonPlaysGames ASpoonPlaysGames marked this pull request as ready for review January 16, 2026 02:16
@ASillyNeko

Copy link
Copy Markdown
Contributor

Remove the Northstar.Custom requirement?

@ASpoonPlaysGames

Copy link
Copy Markdown
Contributor Author

Yeah will do, need to sort out conflicts as well

@ASpoonPlaysGames ASpoonPlaysGames added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Jan 20, 2026
@github-actions github-actions Bot removed the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Jan 20, 2026
@catornot

catornot commented Mar 17, 2026

Copy link
Copy Markdown
Member

Is this actually ready for review?
( I will assume that is true )

@catornot catornot self-requested a review March 17, 2026 04:08
@github-actions github-actions Bot added the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Apr 27, 2026
@ASpoonPlaysGames

Copy link
Copy Markdown
Contributor Author

Is this actually ready for review? ( I will assume that is true )

Whoops missed this, yeah it's ready the linked issue is closed

@github-actions github-actions Bot removed the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs code review Changes from PR still need to be reviewed in code needs testing Changes from the PR still need to be tested

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

5 participants