Somewhat better vanilla compat #694
Draft
sonny-tel wants to merge 17 commits into
Draft
Conversation
GeckoEidechse
requested changes
Apr 28, 2024
|
also honestly major issue with this whole approach: if |
Contributor
Author
Touched it up |
you moron. you buffon. I CONTROL ns_is_northstar_server TOO |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
EladNLG
reviewed
May 2, 2024
EladNLG
suggested changes
May 2, 2024
github-actions
Bot
added
the
merge conflicts
Contributor
|
Sonny gotta undraft this and merge r2ion:vanilla++++++++ into northstar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fairly decent improvement on the other low effort Vanilla PRs I made, could be better but I do not have the time to faff about with replicated cvar stuff, do it yourself (see R2Northstar/NorthstarMods#800)