Deferred template - #458
Open
ben-grande wants to merge 5 commits into
Open
Conversation
13 tasks
Contributor
Author
|
Marta, from all the "deferred template" PRs, I think this one is where most discussion regarding user facing changes will happen. Especially these commits:
|
This was referenced Aug 18, 2026
ben-grande
force-pushed
the
deferred-template
branch
from
August 19, 2026 07:12
d6dd7d9 to
ca37be9
Compare
With a server that supports deferred template, clients don't need to worry about the qube state to block template change, in this case, there were only things to remove, as showing "active_template" is irrelevant here, the user just wants to change the "template" property to a new value. For: QubesOS/qubes-issues#8070 Requires: QubesOS/qubes-core-admin#870 Requires: QubesOS/qubes-core-admin-client#496
There is now two warnings for the template value, but they rely on different labels, as it makes it easier to enable them. On the other hand, I could not make the labels be as close to each other, so the label on the last column is much farther away than what would be considered beautiful.
As the server gained support for deferred template, the client doesn't need to worry about the qube state to block template change.
Some features are relevant for the current running qube, such as seamless mode on Windows, in that case, the client needs to query from the "active_template". In other cases, when it is related to a responsibility that is only gained on the next boot, such as boot mode, the query is made targeting the "template" property.
Ideally, we'd inform with icon plus a text description that the "active_template" is different than the "template" property. For now, only the VM settings does that, but still doesn't show the "active_template", as the labels are controlled by the UI files.
ben-grande
force-pushed
the
deferred-template
branch
from
August 19, 2026 07:55
ca37be9 to
735945e
Compare
Contributor
Author
|
Once this PR is merged, it will unblock: |
Contributor
Author
Member
The test expected running qubes not having dropdowns, which is no longer the case with deferred templates. I'll adjust it. |
Contributor
Author
|
Thanks. I see now that I click on the "eye" icon, what the needle was expecting. |
This was referenced Aug 20, 2026
This was referenced Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For: QubesOS/qubes-issues#8070
Requires: QubesOS/qubes-core-admin-client#496
See individual commits messages.