Skip to content

Fix MSI icon in Programs and Features - #2036

Open
MORTEM3845 wants to merge 1 commit into
QL-Win:masterfrom
MORTEM3845:fix/msi-programs-icon
Open

MORTEM3845 wants to merge 1 commit into
QL-Win:masterfrom
MORTEM3845:fix/msi-programs-icon

Conversation

@MORTEM3845

@MORTEM3845 MORTEM3845 commented Oct 24, 2026 •

Copy link
Copy Markdown

PR Checklist

  • Functionality has been tested, no obvious bugs
  • Code style follows project conventions
  • Documentation/comments updated (if applicable; not needed)

Brief Description of Changes

Embed the QuickLook icon in the MSI and set ARPPRODUCTICON so Programs and Features displays the application icon.

Related Issue (if any)

Fixes #2026.

Additional Notes

Validated MSI tables and icon bytes. The reporter of this PR manually installed the modified MSI and confirmed the correct icon in Programs and Features with a screenshot. The full application was not rebuilt.

Summary by CodeRabbit

  • User Experience
    • The installer now uses the QuickLook application icon for its product listing, making it easier to recognize among installed apps.

@coderabbitai

coderabbitai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8c057eda-386c-4b1f-86b5-28b1df2dc668
📥 Commits

Reviewing files that changed from the base of the PR and between 2ec219a and 5c497da.

📒 Files selected for processing: 1
  • QuickLook.Installer/Product.wxs

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

📝 Walkthrough

The MSI configuration now defines the QuickLook icon and assigns it as the product icon shown in Windows Programs and Features.

Changes: Installer Icon Registration

Layer / File(s) Summary
Register the product icon
QuickLook.Installer/Product.wxs
The installer defines QuickLook.ico from the application icon resource and sets ARPPRODUCTICON to use it.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix · Severity of issue fixed: Low

Merge Risk: ⚪ Minimal · up to 5c497

This cosmetic installer change is ready to merge with no actionable risk identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: correcting the MSI icon displayed in Windows Programs and Features.
Linked Issues check Passed Issue #2026 requires the official QuickLook icon in Programs and Features. The PR summary states that QuickLook.Installer/Product.wxs now defines QuickLook.ico from the application icon resource a…
Out of Scope Changes check Passed The supplied change summary reports only three added lines in QuickLook.Installer/Product.wxs. The changes define the MSI icon and set ARPPRODUCTICON, which directly supports issue #2026. No unrel…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Full details: Linked Issues check

Explanation

Issue #2026 requires the official QuickLook icon in Programs and Features. The PR summary states that QuickLook.Installer/Product.wxs now defines QuickLook.ico from the application icon resource and sets ARPPRODUCTICON to use it. These changes address the MSI icon registration requirement. The focused diff was unavailable, so this assessment relies on the supplied PR evidence.

Full details: Out of Scope Changes check

Explanation

The supplied change summary reports only three added lines in QuickLook.Installer/Product.wxs. The changes define the MSI icon and set ARPPRODUCTICON, which directly supports issue #2026. No unrelated change is identified.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] MSI installer does not display the correct application icon in Windows Programs and Features

1 participant