Repository navigation
Fix MSI icon in Programs and Features - #2036
Open
MORTEM3845 wants to merge 1 commit into
Open
MORTEM3845 wants to merge 1 commit into
MORTEM3845 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Brief Description of Changes
Embed the QuickLook icon in the MSI and set
ARPPRODUCTICONso Programs and Features displays the application icon.Related Issue (if any)
Fixes #2026.
Additional Notes
Validated MSI tables and icon bytes. The reporter of this PR manually installed the modified MSI and confirmed the correct icon in Programs and Features with a screenshot. The full application was not rebuilt.
Summary by CodeRabbit