Expose MCP interview reasoning metadata#1140
Conversation
There was a problem hiding this comment.
Review — ouroboros-agent[bot]
Verdict: APPROVE
Branch: feat/mcp-interview-reasoning-surface | 2 files, +204/-3 | CI: Bridge TypeScript pass 14s https://github.com/Q00/ouroboros/actions/runs/26111689250/job/76790306427
Scope: diff-only
HEAD checked: 36eed6912c88c0828b9b9f14045779a4972ca951
What Improved
- Added compact reasoning metadata across the interview response paths while preserving existing response envelopes.
- Added focused assertions for start, resume-pending, and answer metadata; focused tests and ruff pass locally.
Issue Requirements
| Requirement | Status |
|---|---|
No linked issue or identifiable issue requirements in issue.json. |
N/A |
Prior Findings Status
| Prior Finding | Status |
|---|---|
No prior blocker findings were supplied in prev_review.txt; previous bot review approved the PR. |
WITHDRAWN — no blocker exists to maintain or modify against current HEAD 36eed6912c88c0828b9b9f14045779a4972ca951. |
Blockers
| # | File:Line | Severity | Confidence | Finding |
|---|
Follow-ups
| # | File:Line | Priority | Confidence | Suggestion |
|---|
Test Coverage
Coverage is adequate for this PR scope. tests/unit/mcp/tools/test_interview_response_diagnostics.py now verifies reasoning metadata on the main question-bearing paths, and tests/unit/mcp/tools/test_interview_persists_session_on_failure.py covers recoverable failure persistence behavior. Verified locally: uv run pytest tests/unit/mcp/tools/test_interview_response_diagnostics.py tests/unit/mcp/tools/test_interview_persists_session_on_failure.py passed 16 tests; ruff passed for both changed files.
Merge Recommendation
- Ready to merge.
ouroboros-agent[bot]
|
@ouroboros-bot re review ping |
Summary
Tests