Skip to content

Expose MCP interview reasoning metadata#1140

Open
Q00 wants to merge 1 commit into
mainfrom
feat/mcp-interview-reasoning-surface
Open

Expose MCP interview reasoning metadata#1140
Q00 wants to merge 1 commit into
mainfrom
feat/mcp-interview-reasoning-surface

Conversation

@Q00
Copy link
Copy Markdown
Owner

@Q00 Q00 commented May 19, 2026

Summary

  • add compact internal_reasoning and structured interview_reasoning metadata to ouroboros_interview responses
  • cover start, resume, answer, completion, plugin delegation, and recoverable question-generation failure paths
  • extend interview response diagnostics tests to assert the metadata contract

Tests

  • uv run ruff check src/ouroboros/mcp/tools/authoring_handlers.py tests/unit/mcp/tools/test_interview_response_diagnostics.py
  • uv run pytest tests/unit/mcp/tools/test_interview_response_diagnostics.py tests/unit/mcp/tools/test_interview_persists_session_on_failure.py
  • uv run pytest tests/unit/mcp/tools/test_interview_*.py tests/unit/mcp/tools/test_round5_fixes.py

Copy link
Copy Markdown
Contributor

@ouroboros-agent ouroboros-agent Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review — ouroboros-agent[bot]

Verdict: APPROVE

Branch: feat/mcp-interview-reasoning-surface | 2 files, +204/-3 | CI: Bridge TypeScript pass 14s https://github.com/Q00/ouroboros/actions/runs/26111689250/job/76790306427
Scope: diff-only
HEAD checked: 36eed6912c88c0828b9b9f14045779a4972ca951

What Improved

  • Added compact reasoning metadata across the interview response paths while preserving existing response envelopes.
  • Added focused assertions for start, resume-pending, and answer metadata; focused tests and ruff pass locally.

Issue Requirements

Requirement Status
No linked issue or identifiable issue requirements in issue.json. N/A

Prior Findings Status

Prior Finding Status
No prior blocker findings were supplied in prev_review.txt; previous bot review approved the PR. WITHDRAWN — no blocker exists to maintain or modify against current HEAD 36eed6912c88c0828b9b9f14045779a4972ca951.

Blockers

# File:Line Severity Confidence Finding

Follow-ups

# File:Line Priority Confidence Suggestion

Test Coverage

Coverage is adequate for this PR scope. tests/unit/mcp/tools/test_interview_response_diagnostics.py now verifies reasoning metadata on the main question-bearing paths, and tests/unit/mcp/tools/test_interview_persists_session_on_failure.py covers recoverable failure persistence behavior. Verified locally: uv run pytest tests/unit/mcp/tools/test_interview_response_diagnostics.py tests/unit/mcp/tools/test_interview_persists_session_on_failure.py passed 16 tests; ruff passed for both changed files.

Merge Recommendation

  • Ready to merge.

ouroboros-agent[bot]

@Q00
Copy link
Copy Markdown
Owner Author

Q00 commented May 19, 2026

@ouroboros-bot re review ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant