Conversation
added 9 commits
August 25, 2025 15:20
…turn str(self.value)` metamethod, from `Enum` to preserve python 3.8 enum behaviour.
Ran `uv pip compile -U --extra gui --extra docs pyproject.toml > docs/requirements.txt` to forcefully update all packages
…otherwise. Channel 2 overshoots 2.2 V target to 2.212 causing test test_measure_voltage[2.2-channel-2-CH2] to fail as it only accepts +-0.01 V - 2 mV is causing this test to fail, maybe increase the tolerance?
…ed by a 2 mV difference on an unloaded supply. Fixed a copy-pasted comment that wasn't accurate.
Temperaure was removed from the driver, the test has been marked as xfail to respect that. The continuity fail could be from a particularly resistive wire or bad resistor through no fault of the driver. It has not been marked xfail nor had tolerance increased but its failure is reasonable (101 vs 102.06)
…n imprecise modes. Bumped tolerance from 1 ohm to 5 ohm. Fixed float/over-precision error in test_min_avg
Collaborator
|
So I got a bit confused due to the timing changes also being in this PR. The actual changes here are to fix some instrument tests. The python requires doesn't need to be moved off of 3.8. It'd probably be less confusing to abandon this PR and make another one. |
Collaborator
|
Closed in favour of #232 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forcefully updated all dependency listings in
docs/requirements.txtcommit 2ed7b6f and 69cfc6b needs to be reverted as it is handled in #228
modified test tolerances because marginal tolerance failures are a hardware problem not a fixate one. Ideally they should be rolled into a separate PR.
pre-3.13 builds are failing because of the update to
setup.cfgnow being python 3.13.Test things work on jigs
el relays(J287 for ELMv2)J473 Scripts(J473/GG2 Sensor board tester)imac2(Jig 501, Jig 288, Jig 290, Jig 291, USB A -> B cable, Bench power supply, 2x M/M Banana test cables, DMM/multimeter, Oscilloscope with BNC/BNC cable)spectralert_logging(variable power suppy, voltmeter, oscilloscope, Jig 390, Jig 424, Jig 419, environmental chamber)elv_pro(Jig 273, Signal generator, variable power supply, 240 VAC -> 110 VAC stepdown, power amplifier, SMM, Fluke 187/189/287/289, Jig 290, [1x3-way 1x4-way 1x5-way 3x6-way 1x8-way] Phoenix patch cables)