Console Panel Polish and adjustments, ContextMenuBuilder additional h…#245
Merged
michaelsakharov merged 2 commits intoApr 12, 2026
Conversation
xZekro51
commented
Apr 12, 2026
xZekro51
commented
- Polished the Console Panel to give it a more intuitive look
- Improved the Console Functionalities to fully support multiline, collapsing, time toggling
- Added a couple helpers to ContextMenuHelper and EditorGUI
- Minor rework of ContextMenuBuilder
- Now each item can be handled separately via its own struct, all use the IContextMenuItem interface
…elpers and minor rework and ScrollView tweaks
michaelsakharov
left a comment
michaelsakharov
left a comment
Contributor
There was a problem hiding this comment.
Other then that 1 thing, this looks great! The Ui looks amazing thank you so much!!
| float badgeY = rowY + (RowHeight - 14) * 0.5f; | ||
| float stackSize = size * 0.8f; | ||
| float stackY = rowY + totalRowSize * (_multiLine ? 0.75f : 0.5f) - stackSize * 0.5f - 2; | ||
| TextLayout stackTraceLayout = canvas.CreateLayout(msg.StackTrace.StackFrames[0].ToString(), new Prowl.Scribe.TextLayoutSettings { Font = font, PixelSize = stackSize }); |
Contributor
There was a problem hiding this comment.
Could we cache this Text Layout in the entry/msg Creating layouts is a lil expensive since it needs to use the fonts and it constructs the glyph meshes, DrawLayout just draws it and doesnt have to parse/layout anything and is much more performant.
Author
There was a problem hiding this comment.
Absolutely! It makes a lot of sense, I'll push the change right away.
Contributor
|
😍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.