Integrate kpi-calculator from PyPI#63
Merged
Merged
Conversation
jarsarasty
force-pushed
the
feature/kpi-calculator-integration
branch
3 times, most recently
from
a713153 to
685a0eb
Compare
jarsarasty
force-pushed
the
feature/kpi-calculator-integration
branch
9 times, most recently
from
5617f0c to
2122d49
Compare
There was a problem hiding this comment.
Pull request overview
This PR integrates KPI calculation functionality into the simulator-worker by adding the kpi-calculator package from PyPI. The integration adds KPI computation to the simulation workflow while maintaining graceful error handling to ensure simulations can complete even if KPI calculation fails.
Changes:
- Added kpi-calculator>=0.1.1 dependency and updated urllib3 to 2.6.3
- Integrated KPI calculation into simulator_worker.py after simulation completion
- Added convert_simulator_to_kpi_format utility function to transform simulator output format to KPI calculator format
- Added comprehensive integration tests for KPI functionality
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Added kpi-calculator dependency and updated pytest configuration to include new test file |
| dev-requirements.txt | Updated urllib3 dependency version |
| src/simulator_worker/simulator_worker.py | Integrated KPI calculation workflow with error handling |
| src/simulator_worker/utils.py | Added utility function to convert simulator DataFrame format to KPI calculator format |
| unit_test/test_kpi_integration.py | Added comprehensive integration tests for KPI functionality |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jarsarasty
force-pushed
the
feature/kpi-calculator-integration
branch
from
2122d49 to
7ae989c
Compare
jarsarasty
force-pushed
the
feature/kpi-calculator-integration
branch
from
969737b to
5ee1199
Compare
jarsarasty
force-pushed
the
feature/kpi-calculator-integration
branch
from
5ee1199 to
85a8e8c
Compare
jarsarasty
changed the title
jarsarasty
force-pushed
the
feature/kpi-calculator-integration
branch
from
85a8e8c to
6c4befb
Compare
jarsarasty
force-pushed
the
feature/kpi-calculator-integration
branch
from
6c4befb to
770dfb1
Compare
Contributor
Author
|
This PR is now updated with the new pre-release of the KPI calculator. |
jarsarasty
force-pushed
the
feature/kpi-calculator-integration
branch
from
770dfb1 to
3615575
Compare
jarsarasty
force-pushed
the
feature/kpi-calculator-integration
branch
2 times, most recently
from
b2d21ae to
4e5a900
Compare
…imulator worker - Bump kpi-calculator to 0.4.1 - Pass simulation results to calculate_kpis_from_simulator - Embed KPI results in output ESDL via build_esdl_string_with_kpis - Support optional system_lifetime, discount_rate, and round_up_replacement config params - Add end-to-end integration test verifying CAPEX, OPEX, and energy KPIs
jarsarasty
force-pushed
the
feature/kpi-calculator-integration
branch
from
4e5a900 to
6c6f6e0
Compare
samvanderzwan
requested changes
Apr 22, 2026
samvanderzwan
left a comment
samvanderzwan
left a comment
Contributor
There was a problem hiding this comment.
Some small comments
jarsarasty
force-pushed
the
feature/kpi-calculator-integration
branch
3 times, most recently
from
4f54bad to
c2d017f
Compare
…uality
- Bump kpi-calculator to >=0.4.2a1 to get DEFAULT_SYSTEM_LIFETIME_YEARS
and DEFAULT_DISCOUNT_RATE_PERCENT from the public API
- Add save_debug_esdl() to capture input/output ESDL files per run;
opt-in via debug_esdl workflow config key
- Upload debug ESDL as CI artifact on every test run for inspection
- Move _parse_bool_config/_parse_float_config to utils.py with proper
defaults and warnings when system_lifetime or discount_rate are absent
- Rewrite integration tests with unittest.TestCase, AAA pattern, and
setUpClass; add TestAllKPICategories covering all KPI categories
(costs, NPV, energy, CO2 emissions) with debug artifact enabled
jarsarasty
force-pushed
the
feature/kpi-calculator-integration
branch
2 times, most recently
from
1649c9f to
f0c1af5
Compare
Bump kpi-calculator from 0.4.2a1 to 0.4.2a2 in pyproject.toml, requirements.txt, and dev-requirements.txt. Save ESDL files from integration tests to a temp dir with automatic cleanup. Suppress the parameterized mypy warning via config instead of a per-line type: ignore comment.
jarsarasty
force-pushed
the
feature/kpi-calculator-integration
branch
from
f0c1af5 to
bc7cd07
Compare
Contributor
Author
Thank you for your comments, @samvanderzwan. |
Contributor
Author
|
The kpi calculator version can now be updated to v0.4.2a6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kpi-calculator>=0.4.1as a dependencycalculate_kpis_from_simulatorandbuild_esdl_string_with_kpisto compute KPIs and embed the results into the output ESDL stringsystem_lifetime(years),discount_rate(%), andround_up_replacement(bool, defaultTruefor MESIDO optimizer compatibility)