Fix test end scenario sizing head loss#165
Closed
jarsarasty wants to merge 317 commits into
Closed
Conversation
Providing with standard class that can help the post processing when loading data from the resulting jsons. Also some of the functions that create other variables by postprocessing might be placed here, for example velocity and pressure.
bug fix post processing pipe pressure
Updated the heatexchanger heat_to_discharge constraints such that is also working for the bypass when variable temperature are picked on either side of the heat exchanger. This includes a temporary fix for a big_m which is set to infinite when temperature options are available and source is connected with logical link.
* Add exception for NaNs in profile source files * Add NaN check for influxDB profiles
Update casadi to 3.6.7 gil release with highs 1.4.1
* Pipe DN none bug fix in grow_workflow
* upgrade trctools version
* temporary fix for dependencies
Automatically creates documentation for the pycml assets on the variables that are created for them using a decorator that checks for the add_variable method in the assets and its parents. --------- Co-authored-by: Sebastiaan la Fleur <sebastiaan@lfse.nl>
Added states to all asset parameters and started automatic documentation on the modifiers created by esdl_heat_model.
reset POTENTIAL_ERRORS in the grow_workflow
* only fix pandapower dependency issue in test environment
Added a profile adaptation function to allow for copying the profile for the given number of years, relevant for multi-year optimization, independent on the timestep size of the year.
* change definition of power value of heat pump
Generalized select profiles for updates, such that all profiles are set to the new timeseries.
to prevent deletion of potential errors created in asset_to_component_base.py
#288) removed (cop +1) for upper bounds
Added estimate of grow workflow taks completion to be used in the OMOTES backend
update pyesdl & pycore version
- added profileconstraint from the esdl file - added additional constraints for when the producer profile is specified and used in specific watts and not just normalized
* bug fix to prevent asset sizing when state=ENABLED and power profile is specified in watts
* COP of air_water_heatpump is read in financial_mixin to used in variable operational cost * Variable Operation Cost of Air-water-heatpump is function of electricity. Error is resolved. * A new test with a new esdl is added to check the updated Variable Operation Cost of Air-water-heatpump calculated * Formating is done. * Some formating updates are done. * A new test is added to check if variable operation cost calculation is working as desired for air-water-heatpump-elec. * Review comments are addressed * Small modification.
Contributor
Author
|
Incorrect base repository. Pull request will be opened in mesido. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix pipe parameter bug in
test_end_scenario_sizing_head_lossFixed incorrect parameter reference where all pipes were using
pipes[0]parameters instead of their own pipe-specific parameters for diameter,
temperature, and length calculations in head loss validation.
Changed from:
To:
This resolves test failures where theoretical head loss calculations
were incorrect for pipes other than the first one.