Skip to content

Run release health dashboard smoke test in CI#36

Merged
ProfRandom92 merged 2 commits into
mainfrom
codex/add-release-health-smoke-test-to-ci
May 11, 2026
Merged

Run release health dashboard smoke test in CI#36
ProfRandom92 merged 2 commits into
mainfrom
codex/add-release-health-smoke-test-to-ci

Conversation

@ProfRandom92

Copy link
Copy Markdown
Owner

Motivation

  • Ensure the existing release health dashboard smoke test runs automatically on pull requests to catch UI/regression issues early by exercising the synthetic/static dashboard fixtures.
  • Reuse the existing frontend test script and package configuration so no new heavy dependencies or live services are required.

Description

  • Add a new release-health-smoke job to .github/workflows/agent-checks.yml that checks out the repo, sets up Node with actions/setup-node@v4, and configures caching.
  • Install frontend dependencies from dashboard/app using npm ci when dashboard/app/package-lock.json exists and npm install otherwise, then run npm run smoke:release-health in dashboard/app.
  • Keep the existing agent-checks Python job intact so helper script compilation and report generation continue to run.
  • Update docs/AGENT_WORKFLOW.md to document that the release health dashboard smoke test is part of the CI guardrail and close issue #35.

Testing

  • Ran npm ci in dashboard/app and it completed successfully.
  • Ran npm run smoke:release-health in dashboard/app and the smoke script reported Release health dashboard smoke checks passed..
  • Compiled helper scripts with python -m py_compile and the command returned success.
  • Ran python scripts/run_checks.py and it executed and wrote the expected report artifacts successfully.

Codex Task

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation in docs/AGENT_WORKFLOW.md to include the release health dashboard smoke test as part of the CI guardrail. Feedback was provided to clarify that the Node-based smoke test runs separately from the Python checks to avoid environment ambiguity. Additionally, it was noted that the corresponding workflow file mentioned in the documentation is missing from the current changes.

Comment thread docs/AGENT_WORKFLOW.md Outdated
Comment on lines +78 to +80
project health report, generating the dashboard health summary, running the
release health dashboard smoke test from `dashboard/app`, and running the
same safe checks on Python 3.11.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The current phrasing is ambiguous as it implies the Node-based smoke test is included in the "same safe checks" run on Python 3.11. Since the smoke test is a Node script (.mjs), it cannot run in a Python environment. It is better to separate the Node-based smoke test from the Python version checks to avoid this ambiguity.

Additionally, the PR description mentions adding a new job to .github/workflows/agent-checks.yml, but this file is missing from the current pull request changes. If the workflow was not updated, the CI guardrail will not actually execute the new smoke test.

Suggested change
project health report, generating the dashboard health summary, running the
release health dashboard smoke test from `dashboard/app`, and running the
same safe checks on Python 3.11.
project health report, generating the dashboard health summary, and running
the same safe checks on Python 3.11. It also runs the release health
dashboard smoke test from `dashboard/app`.

@ProfRandom92 ProfRandom92 merged commit ab04563 into main May 11, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant